Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(550)

Unified Diff: sync/test/fake_server/fake_server.cc

Issue 2034503003: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //sync (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sync/internal_api/js_sync_encryption_handler_observer_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/test/fake_server/fake_server.cc
diff --git a/sync/test/fake_server/fake_server.cc b/sync/test/fake_server/fake_server.cc
index 0b1229e422beccbcaa3393acded8ad8e623b98be..969906682690210da9ac0050ee9da2253aee6adf 100644
--- a/sync/test/fake_server/fake_server.cc
+++ b/sync/test/fake_server/fake_server.cc
@@ -550,7 +550,7 @@ FakeServer::GetEntitiesAsDictionaryValue() {
// TODO(pvalenzuela): Store more data for each entity so additional
// verification can be performed. One example of additional verification
// is checking the correctness of the bookmark hierarchy.
- list_value->Append(new base::StringValue(entity.GetName()));
+ list_value->AppendString(entity.GetName());
}
return dictionary;
« no previous file with comments | « sync/internal_api/js_sync_encryption_handler_observer_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698