[MD History] Add history-searched-label to embolden the synced device search.

[MD History] Add history-searched-label to embolden the synced device search.

This CL adds a history-searched-label element which bolds the given title
wherever the given search term appears. This element is then used for the
title of history-items and the title in the synced device search.

BUG=610934
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/2ffe3ea4196327e425b7b61ce9affd8cff393d8c
Cr-Commit-Position: refs/heads/master@{#400095}

[calamity, 2016-06-08 04:14:57]

Description was changed from

==========
[MD History] Add history-searched-label to embolden the synced device search.

This CL adds a history-searched-label element which bolds the given title
wherever the given search term appears. This element is then used for the
title of history-items and the title in the synced device search.

BUG=610934
==========

to

==========
[MD History] Add history-searched-label to embolden the synced device search.

This CL adds a history-searched-label element which bolds the given title
wherever the given search term appears. This element is then used for the
title of history-items and the title in the synced device search.

BUG=610934
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[calamity, 2016-06-08 04:30:09]

Patchset #1 (id:1) has been deleted

[calamity, 2016-06-08 04:30:17]

Patchset #1 (id:20001) has been deleted

[calamity, 2016-06-08 04:40:37]

calamity@chromium.org changed reviewers:
+ tsergeant@chromium.org

[calamity, 2016-06-08 04:42:20]

Patchset #1 (id:40001) has been deleted

[tsergeant, 2016-06-08 07:25:06]

Have you checked whether this change had any performance impact? I wouldn't
expect so, but you never know.

https://codereview.chromium.org/2046303002/diff/60001/chrome/browser/browser_...
File chrome/browser/browser_resources.grd (right):

https://codereview.chromium.org/2046303002/diff/60001/chrome/browser/browser_...
chrome/browser/browser_resources.grd:226: <include
name="IDR_MD_HISTORY_SEARCHED_LABEL_HTML"
file="resources\md_history\searched_label.html" type="BINDATA" />
Nit: 'searched' comes before 'shared'

https://codereview.chromium.org/2046303002/diff/60001/chrome/browser/resource...
File chrome/browser/resources/md_history/searched_label.js (right):

https://codereview.chromium.org/2046303002/diff/60001/chrome/browser/resource...
chrome/browser/resources/md_history/searched_label.js:19: * Updates the page
title. If the result was from a search, highlights any
Nit: Update this comment.

https://codereview.chromium.org/2046303002/diff/60001/chrome/browser/resource...
File chrome/browser/resources/md_history/synced_device_manager.html (right):

https://codereview.chromium.org/2046303002/diff/60001/chrome/browser/resource...
chrome/browser/resources/md_history/synced_device_manager.html:22:
separator-indexes="[[syncedDevice.separatorIndexes]]",
No need for the , here

https://codereview.chromium.org/2046303002/diff/60001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/md_history_ui.cc (right):

https://codereview.chromium.org/2046303002/diff/60001/chrome/browser/ui/webui...
chrome/browser/ui/webui/md_history_ui.cc:101:
source->AddResourcePath("searched_label.html",
Nit: 'searched' before 'shared' here too

[calamity, 2016-06-14 01:51:45]

https://codereview.chromium.org/2046303002/diff/60001/chrome/browser/browser_...
File chrome/browser/browser_resources.grd (right):

https://codereview.chromium.org/2046303002/diff/60001/chrome/browser/browser_...
chrome/browser/browser_resources.grd:226: <include
name="IDR_MD_HISTORY_SEARCHED_LABEL_HTML"
file="resources\md_history\searched_label.html" type="BINDATA" />
On 2016/06/08 07:25:06, tsergeant wrote:
> Nit: 'searched' comes before 'shared'

Done.

https://codereview.chromium.org/2046303002/diff/60001/chrome/browser/resource...
File chrome/browser/resources/md_history/searched_label.js (right):

https://codereview.chromium.org/2046303002/diff/60001/chrome/browser/resource...
chrome/browser/resources/md_history/searched_label.js:19: * Updates the page
title. If the result was from a search, highlights any
On 2016/06/08 07:25:06, tsergeant wrote:
> Nit: Update this comment.

Done.

https://codereview.chromium.org/2046303002/diff/60001/chrome/browser/resource...
File chrome/browser/resources/md_history/synced_device_manager.html (right):

https://codereview.chromium.org/2046303002/diff/60001/chrome/browser/resource...
chrome/browser/resources/md_history/synced_device_manager.html:22:
separator-indexes="[[syncedDevice.separatorIndexes]]",
On 2016/06/08 07:25:06, tsergeant wrote:
> No need for the , here

Done.

https://codereview.chromium.org/2046303002/diff/60001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/md_history_ui.cc (right):

https://codereview.chromium.org/2046303002/diff/60001/chrome/browser/ui/webui...
chrome/browser/ui/webui/md_history_ui.cc:101:
source->AddResourcePath("searched_label.html",
On 2016/06/08 07:25:06, tsergeant wrote:
> Nit: 'searched' before 'shared' here too

Done.

[tsergeant, 2016-06-14 04:32:39]

Did you look any further into the performance drop we saw on Friday?

I'm not seeing anything significant on my machine, but what we saw then was
pretty consistent.

[calamity, 2016-06-15 03:41:52]

On 2016/06/14 04:32:39, tsergeant wrote:
> Did you look any further into the performance drop we saw on Friday?
> 
> I'm not seeing anything significant on my machine, but what we saw then was
> pretty consistent.

After testing again, I can't see anything consistent.

[tsergeant, 2016-06-15 04:04:56]

lgtm

[calamity, 2016-06-15 06:30:50]

The CQ bit was checked by calamity@chromium.org

[commit-bot: I haz the power, 2016-06-15 06:31:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2046303002/80001

[commit-bot: I haz the power, 2016-06-15 06:32:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-15 06:32:54]

Try jobs failed on following builders:
  ios-device on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  ios-simulator on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)

[calamity, 2016-06-16 05:53:10]

The CQ bit was checked by calamity@chromium.org

[calamity, 2016-06-16 05:53:11]

The patchset sent to the CQ was uploaded after l-g-t-m from
tsergeant@chromium.org
Link to the patchset: https://codereview.chromium.org/2046303002/#ps120001
(title: "fix tests")

[commit-bot: I haz the power, 2016-06-16 05:53:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2046303002/120001

[commit-bot: I haz the power, 2016-06-16 06:39:30]

Committed patchset #4 (id:120001)

[commit-bot: I haz the power, 2016-06-16 06:41:09]

Description was changed from

==========
[MD History] Add history-searched-label to embolden the synced device search.

This CL adds a history-searched-label element which bolds the given title
wherever the given search term appears. This element is then used for the
title of history-items and the title in the synced device search.

BUG=610934
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD History] Add history-searched-label to embolden the synced device search.

This CL adds a history-searched-label element which bolds the given title
wherever the given search term appears. This element is then used for the
title of history-items and the title in the synced device search.

BUG=610934
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/2ffe3ea4196327e425b7b61ce9affd8cff393d8c
Cr-Commit-Position: refs/heads/master@{#400095}
==========

[commit-bot: I haz the power, 2016-06-16 06:41:10]

Patchset 4 (id:??) landed as
https://crrev.com/2ffe3ea4196327e425b7b61ce9affd8cff393d8c
Cr-Commit-Position: refs/heads/master@{#400095}