Delete the non-static CLD data source logic.

Delete the non-static CLD data source logic.

This obviates the following instructions, which also explain the
concept:
https://www.chromium.org/developers/how-tos/compact-language-detector-cld-data-source-configuration

Basically, nobody ever used the non-static CLD data source and it was a
bunch of dead code hanging around that needed to be maintained. There is
no plan to use anything other than static linking for CLD at this point.

CLD2 is in maintenance mode at this point and will not be receiving any
further improvements. As we look to its replacement, the first step is
to simplify all the code for dealing with CLD.

This is a spiritual revert of this old CL:
https://codereview.chromium.org/461633002/

It was impossible to directly revert due to changes that have entered
the codebase over the past 18 months, but in principle undoes it all.

BUG=367239
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/1e7cf43d74e1343cb4ad64901297040a2cfdfef0
Cr-Commit-Position: refs/heads/master@{#398851}

[Andrew Hayden (chromium.org), 2016-06-06 13:14:45]

Description was changed from

==========
Delete the non-static CLD data source logic.

This obviates the following instructions, which also explain the
concept:
https://www.chromium.org/developers/how-tos/compact-language-detector-cld-dat...

Basically, nobody ever used the non-static CLD data source and it was a
bunch of dead code hanging around that needed to be maintained. There is
no plan to use anything other than static linking for CLD at this point.

BUG=367239
==========

to

==========
Delete the non-static CLD data source logic.

This obviates the following instructions, which also explain the
concept:
https://www.chromium.org/developers/how-tos/compact-language-detector-cld-dat...

Basically, nobody ever used the non-static CLD data source and it was a
bunch of dead code hanging around that needed to be maintained. There is
no plan to use anything other than static linking for CLD at this point.

BUG=367239
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[Andrew Hayden (chromium.org), 2016-06-08 13:13:17]

Description was changed from

==========
Delete the non-static CLD data source logic.

This obviates the following instructions, which also explain the
concept:
https://www.chromium.org/developers/how-tos/compact-language-detector-cld-dat...

Basically, nobody ever used the non-static CLD data source and it was a
bunch of dead code hanging around that needed to be maintained. There is
no plan to use anything other than static linking for CLD at this point.

BUG=367239
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Delete the non-static CLD data source logic.

This obviates the following instructions, which also explain the
concept:
https://www.chromium.org/developers/how-tos/compact-language-detector-cld-dat...

Basically, nobody ever used the non-static CLD data source and it was a
bunch of dead code hanging around that needed to be maintained. There is
no plan to use anything other than static linking for CLD at this point.

CLD2 is in maintenance mode at this point and will not be receiving any
further improvements. As we look to its replacement, the first step is
to simplify all the code for dealing with CLD.

This is a spiritual revert of this old CL:
https://codereview.chromium.org/461633002/

It was impossible to directly revert due to changes that have entered
the codebase over the past 18 months, but in principle undoes it all.

BUG=367239
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[Andrew Hayden (chromium.org), 2016-06-08 13:17:59]

andrewhayden@chromium.org changed reviewers:
+ jam@chromium.org, toyoshim@chromium.org, wfh@chromium.org

[Andrew Hayden (chromium.org), 2016-06-08 13:18:43]

jam:
  BUILD.gn
  chrome/BUILD.gn
  chrome/android/chrome_apk.gyp
  chrome/browser/chrome_browser_main.cc
  chrome/browser/component_updater/cld_component_installer.cc
  chrome/browser/component_updater/cld_component_installer.h
  chrome/browser/component_updater/cld_component_installer_unittest.cc
  chrome/browser/policy/policy_browsertest.cc
  chrome/browser/resources/chromeos/chromevox/BUILD.gn
  chrome/browser/resources/chromeos/chromevox/chromevox_tests.gypi
  chrome/browser/ui/browser_browsertest.cc
  chrome/chrome.gyp
  chrome/test/base/chrome_unit_test_suite.cc
  extensions/BUILD.gn
  extensions/extensions.gyp
  extensions/shell/BUILD.gn
  extensions/shell/app_shell.gyp
  tools/ipc_fuzzer/message_tools/message_list.cc
wfh:
  ipc/ipc_message_start.h
toyoshim:
  .*translate.*
  .*cld.*

[Nico, 2016-06-08 14:44:06]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2016-06-08 14:44:07]

everything except content and extensions (don't have powers there) lgtm

https://codereview.chromium.org/2034413003/diff/80001/chrome/browser/ui/views...
File chrome/browser/ui/views/translate/translate_bubble_view_browsertest.cc
(right):

https://codereview.chromium.org/2034413003/diff/80001/chrome/browser/ui/views...
chrome/browser/ui/views/translate/translate_bubble_view_browsertest.cc:25:
TranslateBubbleViewBrowserTest() {}
just delete this constructor completely

https://codereview.chromium.org/2034413003/diff/80001/extensions/BUILD.gn
File extensions/BUILD.gn (right):

https://codereview.chromium.org/2034413003/diff/80001/extensions/BUILD.gn#new...
extensions/BUILD.gn:97: "//third_party/cld_2:cld_2",
i think you don't need the ":cld_2" part, it should be the default (?) (only in
gn, not in gyp)

https://codereview.chromium.org/2034413003/diff/80001/extensions/extensions.gyp
File extensions/extensions.gyp (right):

https://codereview.chromium.org/2034413003/diff/80001/extensions/extensions.g...
extensions/extensions.gyp:268: '../third_party/cld_2/cld_2.gyp:cld_2',
no tabs please

[Andrew Hayden (chromium.org), 2016-06-08 14:50:50]

https://codereview.chromium.org/2034413003/diff/80001/chrome/browser/ui/views...
File chrome/browser/ui/views/translate/translate_bubble_view_browsertest.cc
(right):

https://codereview.chromium.org/2034413003/diff/80001/chrome/browser/ui/views...
chrome/browser/ui/views/translate/translate_bubble_view_browsertest.cc:25:
TranslateBubbleViewBrowserTest() {}
On 2016/06/08 14:44:07, Nico wrote:
> just delete this constructor completely

Done.

https://codereview.chromium.org/2034413003/diff/80001/extensions/BUILD.gn
File extensions/BUILD.gn (right):

https://codereview.chromium.org/2034413003/diff/80001/extensions/BUILD.gn#new...
extensions/BUILD.gn:97: "//third_party/cld_2:cld_2",
On 2016/06/08 14:44:07, Nico wrote:
> i think you don't need the ":cld_2" part, it should be the default (?) (only
in
> gn, not in gyp)

Whoops!

https://codereview.chromium.org/2034413003/diff/80001/extensions/extensions.gyp
File extensions/extensions.gyp (right):

https://codereview.chromium.org/2034413003/diff/80001/extensions/extensions.g...
extensions/extensions.gyp:268: '../third_party/cld_2/cld_2.gyp:cld_2',
On 2016/06/08 14:44:07, Nico wrote:
> no tabs please

Sorry, copy/paste from the old CL got me :(

[jam, 2016-06-08 16:10:48]

lgtm

[Takashi Toyoshima, 2016-06-09 07:21:28]

lgtm if build issues are fixed.

https://codereview.chromium.org/2034413003/diff/80001/chrome/browser/ui/views...
File chrome/browser/ui/views/translate/translate_bubble_view_browsertest.cc
(right):

https://codereview.chromium.org/2034413003/diff/80001/chrome/browser/ui/views...
chrome/browser/ui/views/translate/translate_bubble_view_browsertest.cc:25:
TranslateBubbleViewBrowserTest() {}
Does this change break the build?

[Takashi Toyoshima, 2016-06-09 07:35:47]

Oops, I find one nit. Could you please fix this before submitting this?

https://codereview.chromium.org/2034413003/diff/100001/chrome/browser/ui/webu...
File chrome/browser/ui/webui/translate_internals/translate_internals_ui.cc
(left):

https://codereview.chromium.org/2034413003/diff/100001/chrome/browser/ui/webu...
chrome/browser/ui/webui/translate_internals/translate_internals_ui.cc:70:
source->AddString("cld-data-source", cld_data_source);
Could you remove relevant code from
chrome/browser/resources/translate_internals/prefs.html?

'<h2>CLD Data Source</h2>' won't be needed any more.

[Andrew Hayden (chromium.org), 2016-06-09 09:34:14]

>
https://codereview.chromium.org/2034413003/diff/80001/chrome/browser/ui/views...
> chrome/browser/ui/views/translate/translate_bubble_view_browsertest.cc:25:
> TranslateBubbleViewBrowserTest() {}
> On 2016/06/08 14:44:07, Nico wrote:
> > just delete this constructor completely
> 
> Done.

Have to add this back, otherwise the individual tests fail to compile, e.g.:
FAILED:
obj/chrome/browser/ui/views/translate/browser_tests.translate_bubble_view_browsertest.o
<snip>
../../chrome/browser/ui/views/translate/translate_bubble_view_browsertest.cc:35:1:
error: constructor for
'TranslateBubbleViewBrowserTest_DISABLED_CloseBrowserWithoutTranslating_Test'
must explicitly initialize the base class 'TranslateBubbleViewBrowserTest' which
does not have a default constructor
IN_PROC_BROWSER_TEST_F(TranslateBubbleViewBrowserTest,
^

(repeated many times for other test macro expansions)

[Andrew Hayden (chromium.org), 2016-06-09 09:37:29]

https://codereview.chromium.org/2034413003/diff/100001/chrome/browser/ui/webu...
File chrome/browser/ui/webui/translate_internals/translate_internals_ui.cc
(left):

https://codereview.chromium.org/2034413003/diff/100001/chrome/browser/ui/webu...
chrome/browser/ui/webui/translate_internals/translate_internals_ui.cc:70:
source->AddString("cld-data-source", cld_data_source);
On 2016/06/09 07:35:46, Takashi Toyoshima wrote:
> Could you remove relevant code from
> chrome/browser/resources/translate_internals/prefs.html?
> 
> '<h2>CLD Data Source</h2>' won't be needed any more.

Whoops! Good catch. Done!

[Takashi Toyoshima, 2016-06-09 09:44:26]

lgtm

[Andrew Hayden (chromium.org), 2016-06-09 11:10:13]

The CQ bit was checked by andrewhayden@chromium.org

[Andrew Hayden (chromium.org), 2016-06-09 11:10:14]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org,
jam@chromium.org, toyoshim@chromium.org
Link to the patchset: https://codereview.chromium.org/2034413003/#ps140001
(title: "rebase to latest master")

[commit-bot: I haz the power, 2016-06-09 11:10:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2034413003/140001

[commit-bot: I haz the power, 2016-06-09 11:17:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-09 11:17:54]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Andrew Hayden (chromium.org), 2016-06-09 11:22:32]

andrewhayden@chromium.org changed reviewers:
+ mkwst@chromium.org
- wfh@chromium.org

[Mike West, 2016-06-09 12:01:19]

Deleting IPC LGTM!

[Andrew Hayden (chromium.org), 2016-06-09 12:36:20]

The CQ bit was checked by andrewhayden@chromium.org

[commit-bot: I haz the power, 2016-06-09 12:36:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2034413003/140001

[commit-bot: I haz the power, 2016-06-09 12:41:41]

Description was changed from

==========
Delete the non-static CLD data source logic.

This obviates the following instructions, which also explain the
concept:
https://www.chromium.org/developers/how-tos/compact-language-detector-cld-dat...

Basically, nobody ever used the non-static CLD data source and it was a
bunch of dead code hanging around that needed to be maintained. There is
no plan to use anything other than static linking for CLD at this point.

CLD2 is in maintenance mode at this point and will not be receiving any
further improvements. As we look to its replacement, the first step is
to simplify all the code for dealing with CLD.

This is a spiritual revert of this old CL:
https://codereview.chromium.org/461633002/

It was impossible to directly revert due to changes that have entered
the codebase over the past 18 months, but in principle undoes it all.

BUG=367239
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Delete the non-static CLD data source logic.

This obviates the following instructions, which also explain the
concept:
https://www.chromium.org/developers/how-tos/compact-language-detector-cld-dat...

Basically, nobody ever used the non-static CLD data source and it was a
bunch of dead code hanging around that needed to be maintained. There is
no plan to use anything other than static linking for CLD at this point.

CLD2 is in maintenance mode at this point and will not be receiving any
further improvements. As we look to its replacement, the first step is
to simplify all the code for dealing with CLD.

This is a spiritual revert of this old CL:
https://codereview.chromium.org/461633002/

It was impossible to directly revert due to changes that have entered
the codebase over the past 18 months, but in principle undoes it all.

BUG=367239
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-06-09 12:41:43]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2016-06-09 12:42:55]

Description was changed from

==========
Delete the non-static CLD data source logic.

This obviates the following instructions, which also explain the
concept:
https://www.chromium.org/developers/how-tos/compact-language-detector-cld-dat...

Basically, nobody ever used the non-static CLD data source and it was a
bunch of dead code hanging around that needed to be maintained. There is
no plan to use anything other than static linking for CLD at this point.

CLD2 is in maintenance mode at this point and will not be receiving any
further improvements. As we look to its replacement, the first step is
to simplify all the code for dealing with CLD.

This is a spiritual revert of this old CL:
https://codereview.chromium.org/461633002/

It was impossible to directly revert due to changes that have entered
the codebase over the past 18 months, but in principle undoes it all.

BUG=367239
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Delete the non-static CLD data source logic.

This obviates the following instructions, which also explain the
concept:
https://www.chromium.org/developers/how-tos/compact-language-detector-cld-dat...

Basically, nobody ever used the non-static CLD data source and it was a
bunch of dead code hanging around that needed to be maintained. There is
no plan to use anything other than static linking for CLD at this point.

CLD2 is in maintenance mode at this point and will not be receiving any
further improvements. As we look to its replacement, the first step is
to simplify all the code for dealing with CLD.

This is a spiritual revert of this old CL:
https://codereview.chromium.org/461633002/

It was impossible to directly revert due to changes that have entered
the codebase over the past 18 months, but in principle undoes it all.

BUG=367239
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/1e7cf43d74e1343cb4ad64901297040a2cfdfef0
Cr-Commit-Position: refs/heads/master@{#398851}
==========

[commit-bot: I haz the power, 2016-06-09 12:42:57]

Patchset 8 (id:??) landed as
https://crrev.com/1e7cf43d74e1343cb4ad64901297040a2cfdfef0
Cr-Commit-Position: refs/heads/master@{#398851}