Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Side by Side Diff: chrome/browser/ui/browser_browsertest.cc

Issue 2034413003: Delete the non-static CLD data source logic. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase to latest master Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/browser.h" 5 #include "chrome/browser/ui/browser.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <memory> 10 #include <memory>
(...skipping 24 matching lines...) Expand all
35 #include "chrome/browser/extensions/tab_helper.h" 35 #include "chrome/browser/extensions/tab_helper.h"
36 #include "chrome/browser/first_run/first_run.h" 36 #include "chrome/browser/first_run/first_run.h"
37 #include "chrome/browser/lifetime/application_lifetime.h" 37 #include "chrome/browser/lifetime/application_lifetime.h"
38 #include "chrome/browser/prefs/incognito_mode_prefs.h" 38 #include "chrome/browser/prefs/incognito_mode_prefs.h"
39 #include "chrome/browser/profiles/profile.h" 39 #include "chrome/browser/profiles/profile.h"
40 #include "chrome/browser/profiles/profile_attributes_storage.h" 40 #include "chrome/browser/profiles/profile_attributes_storage.h"
41 #include "chrome/browser/profiles/profile_manager.h" 41 #include "chrome/browser/profiles/profile_manager.h"
42 #include "chrome/browser/search/search.h" 42 #include "chrome/browser/search/search.h"
43 #include "chrome/browser/sessions/session_service_factory.h" 43 #include "chrome/browser/sessions/session_service_factory.h"
44 #include "chrome/browser/translate/chrome_translate_client.h" 44 #include "chrome/browser/translate/chrome_translate_client.h"
45 #include "chrome/browser/translate/cld_data_harness.h"
46 #include "chrome/browser/translate/cld_data_harness_factory.h"
47 #include "chrome/browser/ui/browser_command_controller.h" 45 #include "chrome/browser/ui/browser_command_controller.h"
48 #include "chrome/browser/ui/browser_commands.h" 46 #include "chrome/browser/ui/browser_commands.h"
49 #include "chrome/browser/ui/browser_finder.h" 47 #include "chrome/browser/ui/browser_finder.h"
50 #include "chrome/browser/ui/browser_list.h" 48 #include "chrome/browser/ui/browser_list.h"
51 #include "chrome/browser/ui/browser_tabstrip.h" 49 #include "chrome/browser/ui/browser_tabstrip.h"
52 #include "chrome/browser/ui/browser_ui_prefs.h" 50 #include "chrome/browser/ui/browser_ui_prefs.h"
53 #include "chrome/browser/ui/browser_window.h" 51 #include "chrome/browser/ui/browser_window.h"
54 #include "chrome/browser/ui/exclusive_access/exclusive_access_context.h" 52 #include "chrome/browser/ui/exclusive_access/exclusive_access_context.h"
55 #include "chrome/browser/ui/exclusive_access/exclusive_access_manager.h" 53 #include "chrome/browser/ui/exclusive_access/exclusive_access_manager.h"
56 #include "chrome/browser/ui/extensions/app_launch_params.h" 54 #include "chrome/browser/ui/extensions/app_launch_params.h"
(...skipping 2787 matching lines...) Expand 10 before | Expand all | Expand 10 after
2844 Browser* browser = new Browser(params); 2842 Browser* browser = new Browser(params);
2845 gfx::Rect bounds = browser->window()->GetBounds(); 2843 gfx::Rect bounds = browser->window()->GetBounds();
2846 2844
2847 // Should be EXPECT_EQ, but this width is inconsistent across platforms. 2845 // Should be EXPECT_EQ, but this width is inconsistent across platforms.
2848 // See https://crbug.com/567925. 2846 // See https://crbug.com/567925.
2849 EXPECT_GE(bounds.width(), 100); 2847 EXPECT_GE(bounds.width(), 100);
2850 EXPECT_EQ(122, bounds.height()); 2848 EXPECT_EQ(122, bounds.height());
2851 browser->window()->Close(); 2849 browser->window()->Close();
2852 } 2850 }
2853 } 2851 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698