third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.h - Issue 2034203002: [DevTools] Improve MainThreadDebugger::memoryInfo

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.h

Issue 2034203002: [DevTools] Improve MainThreadDebugger::memoryInfo (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: added a test Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.h

diff --git a/third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.h b/third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.h

index 53c499d3efab12f4d537a7dbf00932a2d37a52ca..a523e35e00a206fc35ae338ae91504b1e1b7d818 100644

--- a/third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.h

+++ b/third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.h

@@ -59,7 +59,7 @@ public:

bool callingContextCanAccessContext(v8::Local<v8::Context> calling, v8::Local<v8::Context> target) override;

int ensureDefaultContextInGroup(int contextGroupId) override;

- v8::MaybeLocal<v8::Value> memoryInfo(v8::Isolate*, v8::Local<v8::Context>, v8::Local<v8::Object>) override;

+ v8::MaybeLocal<v8::Value> memoryInfo(v8::Isolate*, v8::Local<v8::Context>) override;

protected:

void reportMessageToConsole(v8::Local<v8::Context>, ConsoleMessage*);