third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.cpp - Issue 2034203002: [DevTools] Improve MainThreadDebugger::memoryInfo

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.cpp

Issue 2034203002: [DevTools] Improve MainThreadDebugger::memoryInfo (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: added a test Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.cpp

diff --git a/third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.cpp b/third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.cpp

index 7c2609cb36c785f024198dd339753b19ff1ca2a6..a6ae1745821100f6b4179715a1c2ed34d4a47bea 100644

--- a/third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.cpp

+++ b/third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.cpp

@@ -106,7 +106,7 @@ void WorkerThreadDebugger::reportMessageToConsole(v8::Local<v8::Context> context

executionContext->addConsoleMessage(message);

}

-v8::MaybeLocal<v8::Value> WorkerThreadDebugger::memoryInfo(v8::Isolate*, v8::Local<v8::Context>, v8::Local<v8::Object>)

+v8::MaybeLocal<v8::Value> WorkerThreadDebugger::memoryInfo(v8::Isolate*, v8::Local<v8::Context>)

{

ASSERT_NOT_REACHED();

return v8::MaybeLocal<v8::Value>();