third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp - Issue 2034203002: [DevTools] Improve MainThreadDebugger::memoryInfo

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp

Issue 2034203002: [DevTools] Improve MainThreadDebugger::memoryInfo (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: added a test Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-console-memory.html ('K') | « third_party/WebKit/Source/core/inspector/MainThreadDebugger.h ('k') | third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp

diff --git a/third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp b/third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp

index f00ad8d7889952a2fc975c03cc2bda9a64516476..763f4fa9588f72f869aaad9db6bd28744b79e25c 100644

--- a/third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp

+++ b/third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp

@@ -229,12 +229,12 @@ void MainThreadDebugger::reportMessageToConsole(v8::Local<v8::Context> context,

frame->console().addMessage(consoleMessage);

}

-v8::MaybeLocal<v8::Value> MainThreadDebugger::memoryInfo(v8::Isolate* isolate, v8::Local<v8::Context> context, v8::Local<v8::Object> creationContext)

+v8::MaybeLocal<v8::Value> MainThreadDebugger::memoryInfo(v8::Isolate* isolate, v8::Local<v8::Context> context)

{

ExecutionContext* executionContext = toExecutionContext(context);

ASSERT_UNUSED(executionContext, executionContext);

ASSERT(executionContext->isDocument());

- return toV8(MemoryInfo::create(), creationContext, isolate);

+ return toV8(MemoryInfo::create(), context->Global(), isolate);

}

bool MainThreadDebugger::isCommandLineAPIMethod(const String& name)