third_party/WebKit/Source/core/inspector/MainThreadDebugger.h - Issue 2034203002: [DevTools] Improve MainThreadDebugger::memoryInfo

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/MainThreadDebugger.h

Issue 2034203002: [DevTools] Improve MainThreadDebugger::memoryInfo (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: added a test Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/inspector/MainThreadDebugger.h

diff --git a/third_party/WebKit/Source/core/inspector/MainThreadDebugger.h b/third_party/WebKit/Source/core/inspector/MainThreadDebugger.h

index 185464e71b2fc456cf99da5809b1e84a6966766d..fed0eb26c20390dc1cf8a7b469a4dbc0973e1f34 100644

--- a/third_party/WebKit/Source/core/inspector/MainThreadDebugger.h

+++ b/third_party/WebKit/Source/core/inspector/MainThreadDebugger.h

@@ -71,7 +71,7 @@ public:

static bool isCommandLineAPIMethod(const String& name);

void installAdditionalCommandLineAPI(v8::Local<v8::Context>, v8::Local<v8::Object>) override;

- v8::MaybeLocal<v8::Value> memoryInfo(v8::Isolate*, v8::Local<v8::Context>, v8::Local<v8::Object> creationContext) override;

+ v8::MaybeLocal<v8::Value> memoryInfo(v8::Isolate*, v8::Local<v8::Context>) override;

protected:

void reportMessageToConsole(v8::Local<v8::Context>, ConsoleMessage*) override;