Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(926)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/dom_distiller/content/renderer/distiller_js_render_frame_observer.cc

Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/dom_distiller/content/renderer/distiller_js_render_frame_observer.h ('k') | components/nacl/renderer/nacl_helper.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/dom_distiller/content/renderer/distiller_js_render_frame_observer.cc
diff --git a/components/dom_distiller/content/renderer/distiller_js_render_frame_observer.cc b/components/dom_distiller/content/renderer/distiller_js_render_frame_observer.cc
index a95088b2d10b13b8afb200f8571abedb13423f0f..1a3cef6a061e0c443821eea19d133eb91598123c 100644
--- a/components/dom_distiller/content/renderer/distiller_js_render_frame_observer.cc
+++ b/components/dom_distiller/content/renderer/distiller_js_render_frame_observer.cc
@@ -67,4 +67,8 @@ void DistillerJsRenderFrameObserver::SetIsDistillerPage() {
is_distiller_page_ = true;
}
+void DistillerJsRenderFrameObserver::OnDestruct() {
+ delete this;
+}
+
} // namespace dom_distiller
« no previous file with comments | « components/dom_distiller/content/renderer/distiller_js_render_frame_observer.h ('k') | components/nacl/renderer/nacl_helper.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698