components/contextual_search/renderer/overlay_js_render_frame_observer.cc - Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/contextual_search/renderer/overlay_js_render_frame_observer.cc

Issue 2034153002: Makes RenderFrameObserver/RenderViewObserver::OnDestruct pure virtual. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/contextual_search/renderer/overlay_js_render_frame_observer.h ('k') | components/dom_distiller/content/renderer/distillability_agent.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/contextual_search/renderer/overlay_js_render_frame_observer.cc

diff --git a/components/contextual_search/renderer/overlay_js_render_frame_observer.cc b/components/contextual_search/renderer/overlay_js_render_frame_observer.cc

index ef123cd9f783139f5ab2d969fe15bf5c4ead3400..0966350e8f45797c8d6e4c30c40ea2af496920e3 100644

--- a/components/contextual_search/renderer/overlay_js_render_frame_observer.cc

+++ b/components/contextual_search/renderer/overlay_js_render_frame_observer.cc

@@ -58,4 +58,8 @@ void OverlayJsRenderFrameObserver::DidFinishLoad() {

->RemoveService<mojom::OverlayPageNotifierService>();

}

+void OverlayJsRenderFrameObserver::OnDestruct() {

+ delete this;

} // namespace contextual_search