Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 2034143002: Revert of Gerrit git cl: temporary disable cc option on upload. (Closed)

Created:
4 years, 6 months ago by tandrii(chromium)
Modified:
4 years, 6 months ago
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org, tandrii+omg_git_cl_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert of Gerrit git cl: temporary disable cc option on upload. (patchset #1 id:1 of https://codereview.chromium.org/1895863002/ ) Reason for revert: We've whitelisted cc-ed emails in Gerrit, and so let's try setting cc= again. Original issue's description: > Gerrit git cl: temporary disable cc option on upload. > > Gerrit doesn't allow arbitrary non-member emails for now, > thus removign this feature until either Gerrit allows it, > or we have a per-repo opt-in way. > > TBR=andybons@chromium.org > BUG=604377 > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299988 TBR=andybons@chromium.org,sergiyb@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=604377 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300694

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -10 lines) Patch
M git_cl.py View 1 1 chunk +1 line, -4 lines 0 comments Download
M tests/git_cl_test.py View 1 1 chunk +4 lines, -6 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
tandrii(chromium)
Created Revert of Gerrit git cl: temporary disable cc option on upload.
4 years, 6 months ago (2016-06-03 16:54:39 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2034143002/1
4 years, 6 months ago (2016-06-03 16:55:34 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Depot Tools Presubmit on tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Depot%20Tools%20Presubmit/builds/544)
4 years, 6 months ago (2016-06-03 16:57:45 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2034143002/70001
4 years, 6 months ago (2016-06-03 17:01:43 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-03 17:05:14 UTC) #9
Bons
lgtm
4 years, 6 months ago (2016-06-03 23:15:15 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2034143002/70001
4 years, 6 months ago (2016-06-03 23:15:26 UTC) #12
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 23:18:44 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:70001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=300694

Powered by Google App Engine
This is Rietveld 408576698