Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1271)

Unified Diff: tests/git_cl_test.py

Issue 2034143002: Revert of Gerrit git cl: temporary disable cc option on upload. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Patch Set: rebase Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « git_cl.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/git_cl_test.py
diff --git a/tests/git_cl_test.py b/tests/git_cl_test.py
index 42ffba4f5eaf4ca8711384386a601637f298114f..aa0ee54b4f1e09ad0156ea36b0306fd912b93ecf 100755
--- a/tests/git_cl_test.py
+++ b/tests/git_cl_test.py
@@ -821,18 +821,16 @@ class TestGitCl(TestCase):
expected_upstream_ref + '..' + ref_to_push],), ''),
((['git', 'config', 'rietveld.cc'],), '')
]
- # Add cc from watch list.
- # TODO(tandrii): bring this back after http://crbug.com/604377.
- # if ref_suffix == '':
- # ref_suffix = '%cc=joe@example.com'
- # else:
- # ref_suffix += ',cc=joe@example.com'
notify_suffix = 'notify=%s' % ('ALL' if notify else 'NONE')
if ref_suffix:
ref_suffix += ',' + notify_suffix
else:
ref_suffix = '%' + notify_suffix
+
+ # Add cc from watch list.
+ ref_suffix += ',cc=joe@example.com'
+
if reviewers:
ref_suffix += ',' + ','.join('r=%s' % email
for email in sorted(reviewers))
« no previous file with comments | « git_cl.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698