git_cl.py - Issue 2034143002: Revert of Gerrit git cl: temporary disable cc option on upload.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: git_cl.py

Issue 2034143002: Revert of Gerrit git cl: temporary disable cc option on upload. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Patch Set: rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: git_cl.py

diff --git a/git_cl.py b/git_cl.py

index a08141bbe2967eff217db328b9ce8e9c02c856c2..231b1c438821ddb83134bebe8a6ab3c4988f8119 100755

--- a/git_cl.py

+++ b/git_cl.py

@@ -2498,10 +2498,7 @@ class _GerritChangelistImpl(_ChangelistCodereviewBase):

cc.extend(options.cc)

cc = filter(None, cc)

if cc:

- # refspec_opts.extend('cc=' + email.strip() for email in cc)

- # TODO(tandrii): enable this back. http://crbug.com/604377

- print('WARNING: Gerrit doesn\'t yet support cc-ing arbitrary emails.\n'

- ' Ignoring cc-ed emails. See http://crbug.com/604377.')

+ refspec_opts.extend('cc=' + email.strip() for email in cc)

if change_desc.get_reviewers():

refspec_opts.extend('r=' + email.strip()

« no previous file with comments | « no previous file | tests/git_cl_test.py » ('j') | no next file with comments »