Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2034123003: LCMS: Update FROM_16_TO_8 macro not to raise UBSan error (Closed)

Created:
4 years, 6 months ago by Oliver Chang
Modified:
4 years, 6 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

LCMS: Update FROM_16_TO_8 macro not to raise UBSan error Cherry-picked from upstream commit 6da55e0b51124b795b707d318c0e03252222ba06 BUG=chromium:616253 Committed: https://pdfium.googlesource.com/pdfium/+/79d798da0d4b5f9f1fc27917102bdd7bcfbe863e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
A third_party/lcms2-2.6/0001-from16-to-8-overflow.patch View 1 chunk +13 lines, -0 lines 0 comments Download
M third_party/lcms2-2.6/README.pdfium View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/lcms2-2.6/src/lcms2_internal.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
Oliver Chang
ptal.
4 years, 6 months ago (2016-06-03 16:04:07 UTC) #3
Tom Sepez
lgtm
4 years, 6 months ago (2016-06-03 17:25:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2034123003/1
4 years, 6 months ago (2016-06-03 17:27:09 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 17:27:28 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/79d798da0d4b5f9f1fc27917102bdd7bcfbe...

Powered by Google App Engine
This is Rietveld 408576698