third_party/lcms2-2.6/src/lcms2_internal.h - Issue 2034123003: LCMS: Update FROM_16_TO_8 macro not to raise UBSan error

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/lcms2-2.6/src/lcms2_internal.h

Issue 2034123003: LCMS: Update FROM_16_TO_8 macro not to raise UBSan error (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/lcms2-2.6/src/lcms2_internal.h

diff --git a/third_party/lcms2-2.6/src/lcms2_internal.h b/third_party/lcms2-2.6/src/lcms2_internal.h

index 8617e92eb1442cf024bbaabbc0e6a1fef9f86040..cc76d488d0dcb9f8e0d2004076d79ecffbbfe797 100644

--- a/third_party/lcms2-2.6/src/lcms2_internal.h

+++ b/third_party/lcms2-2.6/src/lcms2_internal.h

@@ -94,7 +94,7 @@

// A fast way to convert from/to 16 <-> 8 bits

#define FROM_8_TO_16(rgb) (cmsUInt16Number) ((((cmsUInt16Number) (rgb)) << 8)|(rgb))

-#define FROM_16_TO_8(rgb) (cmsUInt8Number) ((((rgb) * 65281 + 8388608) >> 24) & 0xFF)

+#define FROM_16_TO_8(rgb) (cmsUInt8Number) ((((cmsUInt32Number)(rgb) * 65281U + 8388608U) >> 24) & 0xFFU)

// Code analysis is broken on asserts

#ifdef _MSC_VER

« no previous file with comments | « third_party/lcms2-2.6/README.pdfium ('k') | no next file » | no next file with comments »