third_party/lcms2-2.6/0001-from16-to-8-overflow.patch - Issue 2034123003: LCMS: Update FROM_16_TO_8 macro not to raise UBSan error

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/lcms2-2.6/0001-from16-to-8-overflow.patch

Issue 2034123003: LCMS: Update FROM_16_TO_8 macro not to raise UBSan error (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 diff --git a/third_party/lcms2-2.6/src/lcms2_internal.h b/third_party/lcms2-2.6/ src/lcms2_internal.h

	2 index 8617e92..cc76d48 100644

	3 --- a/third_party/lcms2-2.6/src/lcms2_internal.h

	4 +++ b/third_party/lcms2-2.6/src/lcms2_internal.h

	5 @@ -94,7 +94,7 @@

	6

	7 // A fast way to convert from/to 16 <-> 8 bits

	8 #define FROM_8_TO_16(rgb) (cmsUInt16Number) ((((cmsUInt16Number) (rgb)) << 8)\|( rgb))

	9 -#define FROM_16_TO_8(rgb) (cmsUInt8Number) ((((rgb) * 65281 + 8388608) >> 24) & 0xFF)

	10 +#define FROM_16_TO_8(rgb) (cmsUInt8Number) ((((cmsUInt32Number)(rgb) * 65281U + 8388608U) >> 24) & 0xFFU)

	11

	12 // Code analysis is broken on asserts

	13 #ifdef _MSC_VER

OLD	NEW

« no previous file with comments | « no previous file | third_party/lcms2-2.6/README.pdfium » ('j') | no next file with comments »