build/config/compiler/BUILD.gn - Issue 2033913002: Don't use WPO for the Clang builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/config/compiler/BUILD.gn

Issue 2033913002: Don't use WPO for the Clang builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@wpo_for_official_x64

Patch Set: Rebase Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/config/compiler/BUILD.gn

diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn

index 7028bb3b9eb1b4ccfb91714c1e7771a580e6b841..3d6fb5d2c1055758a67114408c06fb271041fc3a 100644

--- a/build/config/compiler/BUILD.gn

+++ b/build/config/compiler/BUILD.gn

@@ -1255,7 +1255,8 @@ if (is_win) {

# Default "optimization on" config.

config("optimize") {

if (is_win) {

- if (is_official_build && full_wpo_on_official) {

+ # TODO(thakis): Remove is_clang here, https://crbug.com/598772

+ if (is_official_build && full_wpo_on_official && !is_clang) {

common_optimize_on_cflags += [

"/GL", # Whole program optimization.

« no previous file with comments | « build/common.gypi ('k') | no next file » | no next file with comments »