Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(731)

Side by Side Diff: build/config/compiler/BUILD.gn

Issue 2033913002: Don't use WPO for the Clang builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@wpo_for_official_x64
Patch Set: Rebase Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/common.gypi ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/android/config.gni") 5 import("//build/config/android/config.gni")
6 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
7 import("//build/config/compiler/compiler.gni") 7 import("//build/config/compiler/compiler.gni")
8 import("//build/config/nacl/config.gni") 8 import("//build/config/nacl/config.gni")
9 import("//build/toolchain/cc_wrapper.gni") 9 import("//build/toolchain/cc_wrapper.gni")
10 import("//build/toolchain/toolchain.gni") 10 import("//build/toolchain/toolchain.gni")
(...skipping 1237 matching lines...) Expand 10 before | Expand all | Expand 10 after
1248 # that some libraries aren't needed when they actually are, 1248 # that some libraries aren't needed when they actually are,
1249 # http://crbug.com/234010. As workaround, disable --as-needed. 1249 # http://crbug.com/234010. As workaround, disable --as-needed.
1250 common_optimize_on_ldflags += [ "-Wl,--as-needed" ] 1250 common_optimize_on_ldflags += [ "-Wl,--as-needed" ]
1251 } 1251 }
1252 } 1252 }
1253 } 1253 }
1254 1254
1255 # Default "optimization on" config. 1255 # Default "optimization on" config.
1256 config("optimize") { 1256 config("optimize") {
1257 if (is_win) { 1257 if (is_win) {
1258 if (is_official_build && full_wpo_on_official) { 1258 # TODO(thakis): Remove is_clang here, https://crbug.com/598772
1259 if (is_official_build && full_wpo_on_official && !is_clang) {
1259 common_optimize_on_cflags += [ 1260 common_optimize_on_cflags += [
1260 "/GL", # Whole program optimization. 1261 "/GL", # Whole program optimization.
1261 1262
1262 # Disable Warning 4702 ("Unreachable code") for the WPO/PGO builds. 1263 # Disable Warning 4702 ("Unreachable code") for the WPO/PGO builds.
1263 # Probably anything that this would catch that wouldn't be caught in a 1264 # Probably anything that this would catch that wouldn't be caught in a
1264 # normal build isn't going to actually be a bug, so the incremental 1265 # normal build isn't going to actually be a bug, so the incremental
1265 # value of C4702 for PGO builds is likely very small. 1266 # value of C4702 for PGO builds is likely very small.
1266 "/wd4702", 1267 "/wd4702",
1267 ] 1268 ]
1268 } 1269 }
(...skipping 198 matching lines...) Expand 10 before | Expand all | Expand 10 after
1467 1468
1468 if (is_ios || is_mac) { 1469 if (is_ios || is_mac) {
1469 # On Mac and iOS, this enables support for ARC (automatic ref-counting). 1470 # On Mac and iOS, this enables support for ARC (automatic ref-counting).
1470 # See http://clang.llvm.org/docs/AutomaticReferenceCounting.html. 1471 # See http://clang.llvm.org/docs/AutomaticReferenceCounting.html.
1471 config("enable_arc") { 1472 config("enable_arc") {
1472 common_flags = [ "-fobjc-arc" ] 1473 common_flags = [ "-fobjc-arc" ]
1473 cflags_objc = common_flags 1474 cflags_objc = common_flags
1474 cflags_objcc = common_flags 1475 cflags_objcc = common_flags
1475 } 1476 }
1476 } 1477 }
OLDNEW
« no previous file with comments | « build/common.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698