Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Unified Diff: build/common.gypi

Issue 2033913002: Don't use WPO for the Clang builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@wpo_for_official_x64
Patch Set: Rebase Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/config/compiler/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index c172ff4798715a655ba7b8fc3aa2a4eb5949ea5d..85de286f558fd968ab0ca3d542c2605e7aa9ce20 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -5501,7 +5501,8 @@
# 2, favorSize - Favor small code (/Os)
'FavorSizeOrSpeed': '2',
'conditions': [
- ['full_wpo_on_official==1', {
+ # TODO(thakis): Remove clang==0 here, crbug.com/598772
+ ['full_wpo_on_official==1 and clang==0', {
# This implies link time code generation.
'WholeProgramOptimization': 'true',
}],
@@ -5529,7 +5530,8 @@
# 1, favorSpeed - Favor fast code (/Ot)
'FavorSizeOrSpeed': '1',
'conditions': [
- ['full_wpo_on_official==1', {
+ # TODO(thakis): Remove clang==0 here, crbug.com/598772
+ ['full_wpo_on_official==1 and clang==0', {
# This implies link time code generation.
'WholeProgramOptimization': 'true',
}],
« no previous file with comments | « no previous file | build/config/compiler/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698