Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Side by Side Diff: build/common.gypi

Issue 2033913002: Don't use WPO for the Clang builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@wpo_for_official_x64
Patch Set: Rebase Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | build/config/compiler/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 # Variables expected to be overriden on the GYP command line (-D) or by 9 # Variables expected to be overriden on the GYP command line (-D) or by
10 # ~/.gyp/include.gypi. 10 # ~/.gyp/include.gypi.
(...skipping 5483 matching lines...) Expand 10 before | Expand all | Expand 10 after
5494 }, 5494 },
5495 'target_conditions': [ 5495 'target_conditions': [
5496 ['optimize=="size"', { 5496 ['optimize=="size"', {
5497 'msvs_settings': { 5497 'msvs_settings': {
5498 'VCCLCompilerTool': { 5498 'VCCLCompilerTool': {
5499 # 1, optimizeMinSpace, Minimize Size (/O1) 5499 # 1, optimizeMinSpace, Minimize Size (/O1)
5500 'Optimization': '1', 5500 'Optimization': '1',
5501 # 2, favorSize - Favor small code (/Os) 5501 # 2, favorSize - Favor small code (/Os)
5502 'FavorSizeOrSpeed': '2', 5502 'FavorSizeOrSpeed': '2',
5503 'conditions': [ 5503 'conditions': [
5504 ['full_wpo_on_official==1', { 5504 # TODO(thakis): Remove clang==0 here, crbug.com/598772
5505 ['full_wpo_on_official==1 and clang==0', {
5505 # This implies link time code generation. 5506 # This implies link time code generation.
5506 'WholeProgramOptimization': 'true', 5507 'WholeProgramOptimization': 'true',
5507 }], 5508 }],
5508 ], 5509 ],
5509 }, 5510 },
5510 }, 5511 },
5511 }], 5512 }],
5512 # This config is used to avoid a problem in ffmpeg, see 5513 # This config is used to avoid a problem in ffmpeg, see
5513 # http://crbug.com/264459. 5514 # http://crbug.com/264459.
5514 ['optimize=="size_no_ltcg"', { 5515 ['optimize=="size_no_ltcg"', {
5515 'msvs_settings': { 5516 'msvs_settings': {
5516 'VCCLCompilerTool': { 5517 'VCCLCompilerTool': {
5517 # 1, optimizeMinSpace, Minimize Size (/O1) 5518 # 1, optimizeMinSpace, Minimize Size (/O1)
5518 'Optimization': '1', 5519 'Optimization': '1',
5519 # 2, favorSize - Favor small code (/Os) 5520 # 2, favorSize - Favor small code (/Os)
5520 'FavorSizeOrSpeed': '2', 5521 'FavorSizeOrSpeed': '2',
5521 }, 5522 },
5522 }, 5523 },
5523 }], 5524 }],
5524 ['optimize=="speed"', { 5525 ['optimize=="speed"', {
5525 'msvs_settings': { 5526 'msvs_settings': {
5526 'VCCLCompilerTool': { 5527 'VCCLCompilerTool': {
5527 # 2, optimizeMaxSpeed, Maximize Speed (/O2) 5528 # 2, optimizeMaxSpeed, Maximize Speed (/O2)
5528 'Optimization': '2', 5529 'Optimization': '2',
5529 # 1, favorSpeed - Favor fast code (/Ot) 5530 # 1, favorSpeed - Favor fast code (/Ot)
5530 'FavorSizeOrSpeed': '1', 5531 'FavorSizeOrSpeed': '1',
5531 'conditions': [ 5532 'conditions': [
5532 ['full_wpo_on_official==1', { 5533 # TODO(thakis): Remove clang==0 here, crbug.com/598772
5534 ['full_wpo_on_official==1 and clang==0', {
5533 # This implies link time code generation. 5535 # This implies link time code generation.
5534 'WholeProgramOptimization': 'true', 5536 'WholeProgramOptimization': 'true',
5535 }], 5537 }],
5536 ], 5538 ],
5537 }, 5539 },
5538 }, 5540 },
5539 }], 5541 }],
5540 ['optimize=="max"', { 5542 ['optimize=="max"', {
5541 # Disable Warning 4702 ("Unreachable code") for the WPO/PGO 5543 # Disable Warning 4702 ("Unreachable code") for the WPO/PGO
5542 # builds. Probably anything that this would catch that 5544 # builds. Probably anything that this would catch that
(...skipping 783 matching lines...) Expand 10 before | Expand all | Expand 10 after
6326 # settings in target dicts. SYMROOT is a special case, because many other 6328 # settings in target dicts. SYMROOT is a special case, because many other
6327 # Xcode variables depend on it, including variables such as 6329 # Xcode variables depend on it, including variables such as
6328 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something 6330 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something
6329 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the 6331 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
6330 # files to appear (when present) in the UI as actual files and not red 6332 # files to appear (when present) in the UI as actual files and not red
6331 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, 6333 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
6332 # and therefore SYMROOT, needs to be set at the project level. 6334 # and therefore SYMROOT, needs to be set at the project level.
6333 'SYMROOT': '<(DEPTH)/xcodebuild', 6335 'SYMROOT': '<(DEPTH)/xcodebuild',
6334 }, 6336 },
6335 } 6337 }
OLDNEW
« no previous file with comments | « no previous file | build/config/compiler/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698