Issue 2033893004: Align semantics of getDefaultConstructor()

Issue 2033893004: Align semantics of getDefaultConstructor() (Closed)

Created:
4 years, 6 months ago by Johnni Winther

Modified:
4 years, 6 months ago

Reviewers:
Siggi Cherem (dart-lang), Harry Terkelsen

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Align semantics of getDefaultConstructor() The modelx implementation of getDefaultConstructor() (surprisingly) returned constructors with only optional arguments. This CL aligns the modelz implementation with this, adding a TODO to figure out what the best behavior is. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/e97c1c673f9328c1b8754497d5b3b92da13daa4c

Created: 4 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -1 line)			Patch
M	pkg/compiler/lib/src/elements/elements.dart	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	pkg/compiler/lib/src/serialization/modelz.dart	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	tests/compiler/dart2js/serialization/equivalence_test.dart	View	1 chunk	+4 lines, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

Johnni Winther

4 years, 6 months ago (2016-06-06 09:23:29 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
e97c1c673f9328c1b8754497d5b3b92da13daa4c (presubmit successful).