pkg/compiler/lib/src/serialization/modelz.dart - Issue 2033893004: Align semantics of getDefaultConstructor()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/serialization/modelz.dart

Issue 2033893004: Align semantics of getDefaultConstructor() (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/serialization/modelz.dart

diff --git a/pkg/compiler/lib/src/serialization/modelz.dart b/pkg/compiler/lib/src/serialization/modelz.dart

index 87f5fbceea5a8f8b7dcc1560eb4420f003181e21..a03ef2f2b12f68251d0365defecf0bac6df40494 100644

--- a/pkg/compiler/lib/src/serialization/modelz.dart

+++ b/pkg/compiler/lib/src/serialization/modelz.dart

@@ -835,7 +835,8 @@ abstract class ClassElementMixin

@override

ConstructorElement lookupDefaultConstructor() {

ConstructorElement constructor = lookupConstructor("");

- if (constructor != null && constructor.parameters.isEmpty) {

+ if (constructor != null &&

+ constructor.functionSignature.requiredParameterCount == 0) {

return constructor;

}

return null;