Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Side by Side Diff: pkg/compiler/lib/src/serialization/modelz.dart

Issue 2033893004: Align semantics of getDefaultConstructor() (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 /// Implementation of the element model used for deserialiation. 5 /// Implementation of the element model used for deserialiation.
6 /// 6 ///
7 /// These classes are created by [ElementDeserializer] triggered by the 7 /// These classes are created by [ElementDeserializer] triggered by the
8 /// [Deserializer]. 8 /// [Deserializer].
9 9
10 library dart2js.serialization.modelz; 10 library dart2js.serialization.modelz;
(...skipping 817 matching lines...) Expand 10 before | Expand all | Expand 10 after
828 828
829 @override 829 @override
830 bool get hasLocalScopeMembers => _unsupported('hasLocalScopeMembers'); 830 bool get hasLocalScopeMembers => _unsupported('hasLocalScopeMembers');
831 831
832 @override 832 @override
833 bool get isEnumClass => false; 833 bool get isEnumClass => false;
834 834
835 @override 835 @override
836 ConstructorElement lookupDefaultConstructor() { 836 ConstructorElement lookupDefaultConstructor() {
837 ConstructorElement constructor = lookupConstructor(""); 837 ConstructorElement constructor = lookupConstructor("");
838 if (constructor != null && constructor.parameters.isEmpty) { 838 if (constructor != null &&
839 constructor.functionSignature.requiredParameterCount == 0) {
839 return constructor; 840 return constructor;
840 } 841 }
841 return null; 842 return null;
842 } 843 }
843 844
844 @override 845 @override
845 ClassElement get superclass => supertype != null ? supertype.element : null; 846 ClassElement get superclass => supertype != null ? supertype.element : null;
846 847
847 @override 848 @override
848 void ensureResolved(Resolution resolution) { 849 void ensureResolved(Resolution resolution) {
(...skipping 1406 matching lines...) Expand 10 before | Expand all | Expand 10 after
2255 } 2256 }
2256 2257
2257 @override 2258 @override
2258 ElementKind get kind => ElementKind.PREFIX; 2259 ElementKind get kind => ElementKind.PREFIX;
2259 2260
2260 @override 2261 @override
2261 Element lookupLocalMember(String memberName) { 2262 Element lookupLocalMember(String memberName) {
2262 return _unsupported('lookupLocalMember'); 2263 return _unsupported('lookupLocalMember');
2263 } 2264 }
2264 } 2265 }
OLDNEW
« no previous file with comments | « pkg/compiler/lib/src/elements/elements.dart ('k') | tests/compiler/dart2js/serialization/equivalence_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698