Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 2033713004: third_party: Update to version 2 of remote_shell_protocol. (Closed)

Created:
4 years, 6 months ago by reveman
Modified:
4 years, 6 months ago
Reviewers:
mtomasz, piman
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

third_party: Update to version 2 of remote_shell_protocol. Adds support for maximize and minimize as well as allowing the client to request that window is made fullscreen. BUG=549781 TBR=piman@chromium.org Committed: https://crrev.com/cdfcdfb958837576315ec711fdcfbb39ab96b6c8 Cr-Commit-Position: refs/heads/master@{#397942}

Patch Set 1 #

Total comments: 4

Patch Set 2 : fix typos #

Messages

Total messages: 13 (6 generated)
mtomasz
lgtm https://codereview.chromium.org/2033713004/diff/1/third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml File third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml (right): https://codereview.chromium.org/2033713004/diff/1/third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml#newcode235 third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml:235: This is only a request that the window ...
4 years, 6 months ago (2016-06-03 03:56:42 UTC) #2
mtomasz
https://codereview.chromium.org/2033713004/diff/1/third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml File third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml (right): https://codereview.chromium.org/2033713004/diff/1/third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml#newcode275 third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml:275: <event name="set_minimize" since="2"> nit: set_minimized
4 years, 6 months ago (2016-06-03 06:30:30 UTC) #3
reveman
https://codereview.chromium.org/2033713004/diff/1/third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml File third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml (right): https://codereview.chromium.org/2033713004/diff/1/third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml#newcode235 third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml:235: This is only a request that the window should ...
4 years, 6 months ago (2016-06-03 11:25:30 UTC) #4
reveman
+piman
4 years, 6 months ago (2016-06-05 02:53:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2033713004/20001
4 years, 6 months ago (2016-06-05 02:53:36 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-05 20:05:32 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-06-05 20:07:30 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cdfcdfb958837576315ec711fdcfbb39ab96b6c8
Cr-Commit-Position: refs/heads/master@{#397942}

Powered by Google App Engine
This is Rietveld 408576698