exo: Implement version 2 of remote shell interface.

exo: Implement version 2 of remote shell interface.

Adds support for maximize and minimize as well as allowing the
client to request that window is made fullscreen.

BUG=549781
TEST=exo_unittests

Committed: https://crrev.com/53521434cb53901bd186ff74db37938076b46e7b
Cr-Commit-Position: refs/heads/master@{#397976}

[reveman, 2016-06-04 23:14:25]

reveman@chromium.org changed reviewers:
+ dcastagna@chromium.org

[Daniele Castagna, 2016-06-06 03:11:23]

LGTM

https://codereview.chromium.org/2040743002/diff/20001/components/exo/wayland/...
File components/exo/wayland/server.cc (right):

https://codereview.chromium.org/2040743002/diff/20001/components/exo/wayland/...
components/exo/wayland/server.cc:1394: void remote_surface_fullscreen(wl_client*
client, wl_resource* resource) {
This file could be probably made much compact with a little bit of
metaprogramming.

https://codereview.chromium.org/2040743002/diff/20001/components/exo/wayland/...
components/exo/wayland/server.cc:1554: if (wl_resource_get_version(resource) >=
2)
Wouldn't this code be clearer if it was something like

if (wl_resource_get_version(resource) >= 2) {
  switch(old_state) {
  }
  switch(new_state) {
  }
} else [
  bla bla
}

Also, would there ever be a reason why you might not want to unset and set a
state if it ends up in the same state?

[reveman, 2016-06-06 03:26:57]

https://codereview.chromium.org/2040743002/diff/20001/components/exo/wayland/...
File components/exo/wayland/server.cc (right):

https://codereview.chromium.org/2040743002/diff/20001/components/exo/wayland/...
components/exo/wayland/server.cc:1394: void remote_surface_fullscreen(wl_client*
client, wl_resource* resource) {
On 2016/06/06 at 03:11:23, Daniele Castagna wrote:
> This file could be probably made much compact with a little bit of
metaprogramming.

Yes, that was always the plan but it's been easier to just copy-paste for now.
If you have some good suggestions for how to eliminate some of this boiler plate
code than let's discuss that and try to get it done.

https://codereview.chromium.org/2040743002/diff/20001/components/exo/wayland/...
components/exo/wayland/server.cc:1554: if (wl_resource_get_version(resource) >=
2)
On 2016/06/06 at 03:11:23, Daniele Castagna wrote:
> Wouldn't this code be clearer if it was something like
> 
> if (wl_resource_get_version(resource) >= 2) {
>   switch(old_state) {
>   }
>   switch(new_state) {
>   }
> } else [
>   bla bla
> }

I'm expecting "wl_resource_get_version(resource) >= 3" in the future so I think
the current code will be easier to ready for that reason.

> 
> Also, would there ever be a reason why you might not want to unset and set a
state if it ends up in the same state?

Maybe but I have the DCHECK above that assumes this will never be called in that
way. And that is the case for chrome today afaict.

[reveman, 2016-06-06 04:42:33]

The CQ bit was checked by reveman@chromium.org

[commit-bot: I haz the power, 2016-06-06 04:42:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2040743002/20001

[commit-bot: I haz the power, 2016-06-06 05:16:50]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-06 05:17:50]

Description was changed from

==========
exo: Implement version 2 of remote shell interface.

Adds support for maximize and minimize as well as allowing the
client to request that window is made fullscreen.

BUG=549781
TEST=exo_unittests
==========

to

==========
exo: Implement version 2 of remote shell interface.

Adds support for maximize and minimize as well as allowing the
client to request that window is made fullscreen.

BUG=549781
TEST=exo_unittests

Committed: https://crrev.com/53521434cb53901bd186ff74db37938076b46e7b
Cr-Commit-Position: refs/heads/master@{#397976}
==========

[commit-bot: I haz the power, 2016-06-06 05:17:51]

Patchset 2 (id:??) landed as
https://crrev.com/53521434cb53901bd186ff74db37938076b46e7b
Cr-Commit-Position: refs/heads/master@{#397976}