Removing Chromoting's dependence on the sas.dll

Removing the sas.dll dependency from the Chromoting MSI

The sas.dll was originally added to allow Chromtoing to inject the Secure
Attention Sequence (SAS).  Win7 and later OSes have an API for doing this
however we needed to support this functionality on XP and Vista and using the
redist sas.dll allows this.  Since we no longer need to support OSes earlier
than Win7/W2k8R2, we can call the OS API instead of using the version exposed
in sas.dll.

Removing this dependency also cleans up our code and reduces our pacakge size.

I don't think anyone else is using this dll so I am going to submit a follow-up
CL to remove the higher level GYP variables after this lands.

BUG=606385
Committed: https://crrev.com/19d55d345af78a83f3ef181004b8f475377cc354
Cr-Commit-Position: refs/heads/master@{#397798}

[joedow, 2016-06-03 16:13:28]

Description was changed from

==========
Removing Chromoting's dependence on the sas.dll

Since we no longer support OSes older than Win7/W2K8R2, we no longer need the
sas.dll to inject the Ctrl+Alt+Del for us as we can call the API directly.

Removing the DLL reduces our package size and simplifies dependencies and code.

BUG=606385
==========

to

==========
Removing the sas.dll dependency from the Chromoting MSI

The sas.dll was originally added to allow Chromtoing to inject the Secure
Attention Sequence (SAS).  Win7 and later OSes have an API for doing this
however we needed to support this functionality on XP and Vista and using the
redist sas.dll allows this.  Since we no longer need to support OSes earlier
than Win7/W2k8R2, we can call the OS API instead of using the version exposed
in sas.dll.

Removing this dependency also cleans up our code and reduces our pacakge size.

I don't think anyone else is using this dll so I am going to submit a follow-up
CL to remove the higher level GYP variables after this lands.

BUG=606385
==========

[joedow, 2016-06-03 16:17:19]

joedow@chromium.org changed reviewers:
+ jamiewalch@chromium.org*, zijiehe@chromium.org

[joedow, 2016-06-03 16:17:20]

PTAL!

[joedow, 2016-06-03 16:19:01]

joedow@chromium.org changed reviewers:
+ jamiewalch@chromium.org
- jamiewalch@chromium.org*

[joedow, 2016-06-03 16:19:01]

joedow@chromium.org changed required reviewers:
+ jamiewalch@chromium.org

[joedow, 2016-06-03 16:19:02]

Fixing the reviewers list :)

[Jamie, 2016-06-03 17:49:31]

lgtm

https://codereview.chromium.org/2033683003/diff/20001/remoting/host/BUILD.gn
File remoting/host/BUILD.gn (left):

https://codereview.chromium.org/2033683003/diff/20001/remoting/host/BUILD.gn#...
remoting/host/BUILD.gn:1097: "$_redist_cpu_path/sas.dll",
Can the file be removed as well?

https://codereview.chromium.org/2033683003/diff/20001/remoting/host/sas_injec...
File remoting/host/sas_injector_win.cc (right):

https://codereview.chromium.org/2033683003/diff/20001/remoting/host/sas_injec...
remoting/host/sas_injector_win.cc:93: // Sends Secure Attention Sequence using
the SendSAS() method.  Checks the
I'm not sure that mentioning the API in the comment is appropriate any more
(otherwise we would do it in every comment!)

In fact, given the comment in InjectSas, I don't think we need this comment at
all.

[joedow, 2016-06-03 18:11:02]

Thanks!

https://codereview.chromium.org/2033683003/diff/20001/remoting/host/BUILD.gn
File remoting/host/BUILD.gn (left):

https://codereview.chromium.org/2033683003/diff/20001/remoting/host/BUILD.gn#...
remoting/host/BUILD.gn:1097: "$_redist_cpu_path/sas.dll",
On 2016/06/03 17:49:31, Jamie wrote:
> Can the file be removed as well?

I have a follow up CL which removes the remnants of this dependency outside of
the Chromoting directory which will take care of this.

https://codereview.chromium.org/2033683003/diff/20001/remoting/host/sas_injec...
File remoting/host/sas_injector_win.cc (right):

https://codereview.chromium.org/2033683003/diff/20001/remoting/host/sas_injec...
remoting/host/sas_injector_win.cc:93: // Sends Secure Attention Sequence using
the SendSAS() method.  Checks the
On 2016/06/03 17:49:31, Jamie wrote:
> I'm not sure that mentioning the API in the comment is appropriate any more
> (otherwise we would do it in every comment!)
> 
> In fact, given the comment in InjectSas, I don't think we need this comment at
> all.

Done.

[joedow, 2016-06-03 18:11:08]

The CQ bit was checked by joedow@chromium.org

[joedow, 2016-06-03 18:11:09]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamiewalch@chromium.org
Link to the patchset: https://codereview.chromium.org/2033683003/#ps40001
(title: "Updating comment")

[commit-bot: I haz the power, 2016-06-03 18:11:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2033683003/40001

[commit-bot: I haz the power, 2016-06-03 19:32:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-03 19:32:32]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[joedow, 2016-06-03 20:24:19]

The CQ bit was checked by joedow@chromium.org

[commit-bot: I haz the power, 2016-06-03 20:24:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2033683003/40001

[commit-bot: I haz the power, 2016-06-03 20:55:31]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-03 20:57:35]

Description was changed from

==========
Removing the sas.dll dependency from the Chromoting MSI

The sas.dll was originally added to allow Chromtoing to inject the Secure
Attention Sequence (SAS).  Win7 and later OSes have an API for doing this
however we needed to support this functionality on XP and Vista and using the
redist sas.dll allows this.  Since we no longer need to support OSes earlier
than Win7/W2k8R2, we can call the OS API instead of using the version exposed
in sas.dll.

Removing this dependency also cleans up our code and reduces our pacakge size.

I don't think anyone else is using this dll so I am going to submit a follow-up
CL to remove the higher level GYP variables after this lands.

BUG=606385
==========

to

==========
Removing the sas.dll dependency from the Chromoting MSI

The sas.dll was originally added to allow Chromtoing to inject the Secure
Attention Sequence (SAS).  Win7 and later OSes have an API for doing this
however we needed to support this functionality on XP and Vista and using the
redist sas.dll allows this.  Since we no longer need to support OSes earlier
than Win7/W2k8R2, we can call the OS API instead of using the version exposed
in sas.dll.

Removing this dependency also cleans up our code and reduces our pacakge size.

I don't think anyone else is using this dll so I am going to submit a follow-up
CL to remove the higher level GYP variables after this lands.

BUG=606385

Committed: https://crrev.com/19d55d345af78a83f3ef181004b8f475377cc354
Cr-Commit-Position: refs/heads/master@{#397798}
==========

[commit-bot: I haz the power, 2016-06-03 20:57:36]

Patchset 3 (id:??) landed as
https://crrev.com/19d55d345af78a83f3ef181004b8f475377cc354
Cr-Commit-Position: refs/heads/master@{#397798}