Removing Chromoting's dependence on the sas.dll

remoting/host/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/features.gni")
 import("//build/config/ui.gni")
 import("//build/config/win/manifest.gni")
 import("//build/util/version.gni")
 import("//remoting/remoting_enable.gni")
 import("//remoting/remoting_locales.gni")
@@ skipping 593 matching lines @@
         "/EXPORT:DllGetClassObject=PsDllGetClassObject,PRIVATE",
         "/EXPORT:DllCanUnloadNow=PsDllCanUnloadNow,PRIVATE",
         "/EXPORT:DllRegisterServer=PsDllRegisterServer,PRIVATE",
         "/EXPORT:DllUnregisterServer=PsDllUnregisterServer,PRIVATE",
       ]
 
       libs = [
         "comctl32.lib",
         "rpcns4.lib",
         "rpcrt4.lib",
+        "sas.lib",
         "uuid.lib",
         "wtsapi32.lib",
       ]
 
       if (is_clang) {
         cflags = [ "-Wno-header-hygiene" ]
       }
     }
 
     # GYP version: //remoting/remoting_host_win.gypi:remoting_desktop
@@ skipping 455 matching lines @@
                   "$root_out_dir/remoting_host.exe",
                   "$root_out_dir/remoting_native_messaging_host.exe",
                   "$root_out_dir/remoting_start_host.exe",
                   "$root_gen_dir/remoting/CREDITS.txt",
                   "$root_out_dir/remoting/com.google.chrome.remote_assistance.json",
                   "$root_out_dir/remoting/com.google.chrome.remote_desktop.json",
                   "$root_out_dir/icudtl.dat",
                 ],
                 root_build_dir)
         _extra_files = []
-        if (is_chrome_branded) {
-          if (target_cpu == "x64") {
-            _redist_cpu_path = "amd64"
-          } else {
-            _redist_cpu_path = "x86"
-          }
-          _generated_files +=
-              [ rebase_path("//third_party/platformsdk_win7/files/Redist/" +
-                                "$_redist_cpu_path/sas.dll",

[Jamie, 2016/06/03 17:49:31]

Can the file be removed as well?

[joedow, 2016/06/03 18:11:02]

I have a follow up CL which removes the remnants of this dependency outside of
the Chromoting directory which will take care of this.

-                            root_build_dir) ]
-          _extra_files += [ "files/sas.dll" ]
-        }
 
         args = [
                  rebase_path("$root_gen_dir/installation", root_build_dir),
                  rebase_path(_output, root_build_dir),
                  "--source-file-roots",
                  rebase_path("//remoting/host/installer/win"),
                  "--source-files",
                  rebase_path("//remoting/host/installer/win/chromoting.wxs"),
                  rebase_path("//remoting/host/installer/win/parameters.json"),
 
@@ skipping 57 matching lines @@
           "--target_arch",
           msi_script_arch,
           rebase_path("$root_out_dir/remoting-me2me-host-$current_os.zip",
                       root_build_dir),
           rebase_path(outputs[0], root_build_dir),
         ]
       }
     }
   }
 }