Removing WinXP and Vista specific code from Chromoting.

Removing WinXP and Vista specific code from Chromoting.

Since we no longer support WinXP/WS2K3 and Vista/WS2K8, we can clean up our
code a bit by removing logic and conditions which only apply to those versions.

BUG=607676
Committed: https://crrev.com/7da9460add084b17f47810cd4d4b755638a9c2e3
Cr-Commit-Position: refs/heads/master@{#398169}

[joedow, 2016-06-06 16:46:16]

joedow@chromium.org changed reviewers:
+ jamiewalch@chromium.org, zijiehe@chromium.org

[joedow, 2016-06-06 16:46:16]

joedow@chromium.org changed required reviewers:
+ jamiewalch@chromium.org

[joedow, 2016-06-06 16:46:16]

Removing some unnecessary XP/Vista code and logic from the Remoting Host.  PTAL!

Thanks,
Joe

[Jamie, 2016-06-06 18:05:19]

LGTM, although it probably makes sense to get an LGTM from Zijie as well, in
case there are some Windows subtleties I've missed.

https://codereview.chromium.org/2037163002/diff/20001/remoting/host/win/com_s...
File remoting/host/win/com_security.cc (right):

https://codereview.chromium.org/2037163002/diff/20001/remoting/host/win/com_s...
remoting/host/win/com_security.cc:18: std::string sddl = security_descriptor +
mandatory_label;
Does it still make sense to separate these parameters at the call-site?

[Hzj_jie, 2016-06-06 18:48:54]

LGTM.
Two nits only.

https://codereview.chromium.org/2037163002/diff/20001/remoting/host/win/com_s...
File remoting/host/win/com_security.cc (right):

https://codereview.chromium.org/2037163002/diff/20001/remoting/host/win/com_s...
remoting/host/win/com_security.cc:18: std::string sddl = security_descriptor +
mandatory_label;
On 2016/06/06 18:05:18, Jamie wrote:
> Does it still make sense to separate these parameters at the call-site?

+1

https://codereview.chromium.org/2037163002/diff/20001/remoting/host/win/unpri...
File remoting/host/win/unprivileged_process_delegate.cc (right):

https://codereview.chromium.org/2037163002/diff/20001/remoting/host/win/unpri...
remoting/host/win/unprivileged_process_delegate.cc:144: window_station_sddl +=
kLowIntegrityMandatoryLabel;
Do no need to concat anymore.

[joedow, 2016-06-06 22:49:46]

Thanks!

https://codereview.chromium.org/2037163002/diff/20001/remoting/host/win/com_s...
File remoting/host/win/com_security.cc (right):

https://codereview.chromium.org/2037163002/diff/20001/remoting/host/win/com_s...
remoting/host/win/com_security.cc:18: std::string sddl = security_descriptor +
mandatory_label;
On 2016/06/06 18:48:54, Hzj_jie wrote:
> On 2016/06/06 18:05:18, Jamie wrote:
> > Does it still make sense to separate these parameters at the call-site?
> 
> +1

Acknowledged.  I looked at the two call sites and I think it is cleaner to allow
them to pass the two strings separately and combine them here within the
function.  Sddl strings can get a bit unwieldy (i.e. difficult to parse) if you
try to build everything up at once, I find that it is easier if each logical
piece is defined and combined later on.

https://codereview.chromium.org/2037163002/diff/20001/remoting/host/win/unpri...
File remoting/host/win/unprivileged_process_delegate.cc (right):

https://codereview.chromium.org/2037163002/diff/20001/remoting/host/win/unpri...
remoting/host/win/unprivileged_process_delegate.cc:144: window_station_sddl +=
kLowIntegrityMandatoryLabel;
On 2016/06/06 18:48:54, Hzj_jie wrote:
> Do no need to concat anymore.

Done.  I still want to define the two pieces separately but I've cleaned it up a
bit.

[joedow, 2016-06-06 22:49:52]

The CQ bit was checked by joedow@chromium.org

[joedow, 2016-06-06 22:49:53]

The patchset sent to the CQ was uploaded after l-g-t-m from
zijiehe@chromium.org, jamiewalch@chromium.org
Link to the patchset: https://codereview.chromium.org/2037163002/#ps40001
(title: "Addressing feedback")

[commit-bot: I haz the power, 2016-06-06 22:50:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2037163002/40001

[commit-bot: I haz the power, 2016-06-07 00:18:16]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-07 00:20:46]

Description was changed from

==========
Removing WinXP and Vista specific code from Chromoting.

Since we no longer support WinXP/WS2K3 and Vista/WS2K8, we can clean up our
code a bit by removing logic and conditions which only apply to those versions.

BUG=607676
==========

to

==========
Removing WinXP and Vista specific code from Chromoting.

Since we no longer support WinXP/WS2K3 and Vista/WS2K8, we can clean up our
code a bit by removing logic and conditions which only apply to those versions.

BUG=607676

Committed: https://crrev.com/7da9460add084b17f47810cd4d4b755638a9c2e3
Cr-Commit-Position: refs/heads/master@{#398169}
==========

[commit-bot: I haz the power, 2016-06-07 00:20:47]

Patchset 3 (id:??) landed as
https://crrev.com/7da9460add084b17f47810cd4d4b755638a9c2e3
Cr-Commit-Position: refs/heads/master@{#398169}