Store ScriptWrappableVisitor in V8PerIsolateData

Store ScriptWrappableVisitor in V8PerIsolateData

Store a reference of ScriptWrappableVisitor also in V8PerIsolateData so it can
be accessed from blink code easily (for example when oilpan will want to trace
ScriptWrappableVisitor's marking deque :)

LOG=no
BUG=468240
Committed: https://crrev.com/88755a1fef200479b7c404fba5ab5808560415c6
Cr-Commit-Position: refs/heads/master@{#398003}

[Marcel Hlopko, 2016-06-03 11:46:52]

hlopko@chromium.org changed reviewers:
+ haraken@chromium.org, hpayer@chromium.org, jochen@chromium.org

[Marcel Hlopko, 2016-06-03 11:58:37]

Ptal.

[haraken, 2016-06-03 12:14:03]

OwnPtr is deprecated. Can we use unique_ptr?

(Even if you go with OwnPtr, you need to use PassOwnPtr to pass the pointer
.)

[Marcel Hlopko, 2016-06-03 12:29:58]

Am I using it correctly? First time user of smart pointers :)

[haraken, 2016-06-03 12:32:07]

https://codereview.chromium.org/2033583007/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp (right):

https://codereview.chromium.org/2033583007/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp:295:
isolate->SetEmbedderHeapTracer(visitor);

unique_ptr<ScriptWrappableVisitor> visitor = new ...;
isolate->SetEmbedderHeapTracer(visitor.get());
V8PerIsolateData::from(isolate)->setScriptWrappableVisitor(std::move(visitor));

https://codereview.chromium.org/2033583007/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.h (right):

https://codereview.chromium.org/2033583007/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.h:150: void
setScriptWrappableVisitor(ScriptWrappableVisitor* visitor) {
m_scriptWrappableVisitor = wrapUnique(visitor); }

This function should take unique_ptr<ScriptWrappableVisitor>.

[Marcel Hlopko, 2016-06-03 12:44:44]

Is std::move in setter correct usage? Thank you for the lesson, btw :)

[haraken, 2016-06-03 14:22:45]

LGTM

https://codereview.chromium.org/2033583007/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp (right):

https://codereview.chromium.org/2033583007/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp:293:
std::unique_ptr<ScriptWrappableVisitor> visitor =
std::unique_ptr<ScriptWrappableVisitor>(new ScriptWrappableVisitor(isolate));

std::unique_ptr<> visitor(new ...);

[haraken, 2016-06-03 14:22:56]

On 2016/06/03 12:44:44, Marcel Hlopko wrote:
> Is std::move in setter correct usage? Thank you for the lesson, btw :)

Yes, see
https://chromium.googlesource.com/chromium/src/+/master/third_party/WebKit/So...

[Marcel Hlopko, 2016-06-03 15:04:22]

The CQ bit was checked by hlopko@chromium.org

[Marcel Hlopko, 2016-06-03 15:04:22]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2033583007/#ps80001
(title: "Polish")

[commit-bot: I haz the power, 2016-06-03 15:04:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2033583007/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2033583007/80001

[commit-bot: I haz the power, 2016-06-03 15:49:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-03 15:49:35]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Marcel Hlopko, 2016-06-06 08:17:09]

The CQ bit was checked by hlopko@chromium.org

[Marcel Hlopko, 2016-06-06 08:17:10]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2033583007/#ps100001
(title: "No need to deinitialize")

[commit-bot: I haz the power, 2016-06-06 08:17:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2033583007/100001

[commit-bot: I haz the power, 2016-06-06 09:15:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-06 09:15:19]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Marcel Hlopko, 2016-06-06 10:41:36]

The CQ bit was checked by hlopko@chromium.org

[commit-bot: I haz the power, 2016-06-06 10:41:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2033583007/100001

[commit-bot: I haz the power, 2016-06-06 11:10:17]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-06-06 11:11:42]

Description was changed from

==========
Store ScriptWrappableVisitor in V8PerIsolateData

Store a reference of ScriptWrappableVisitor also in V8PerIsolateData so it can
be accessed from blink code easily (for example when oilpan will want to trace
ScriptWrappableVisitor's marking deque :)

LOG=no
BUG=468240
==========

to

==========
Store ScriptWrappableVisitor in V8PerIsolateData

Store a reference of ScriptWrappableVisitor also in V8PerIsolateData so it can
be accessed from blink code easily (for example when oilpan will want to trace
ScriptWrappableVisitor's marking deque :)

LOG=no
BUG=468240

Committed: https://crrev.com/88755a1fef200479b7c404fba5ab5808560415c6
Cr-Commit-Position: refs/heads/master@{#398003}
==========

[commit-bot: I haz the power, 2016-06-06 11:11:43]

Patchset 6 (id:??) landed as
https://crrev.com/88755a1fef200479b7c404fba5ab5808560415c6
Cr-Commit-Position: refs/heads/master@{#398003}