Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(680)

Side by Side Diff: third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp

Issue 2033583007: Store ScriptWrappableVisitor in V8PerIsolateData (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Use unique_ptr correctly Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 272 matching lines...) Expand 10 before | Expand all | Expand 10 after
283 return policy->allowEval(ScriptState::from(context), ContentSecurity Policy::SendReport, ContentSecurityPolicy::WillThrowException); 283 return policy->allowEval(ScriptState::from(context), ContentSecurity Policy::SendReport, ContentSecurityPolicy::WillThrowException);
284 } 284 }
285 return false; 285 return false;
286 } 286 }
287 287
288 static void initializeV8Common(v8::Isolate* isolate) 288 static void initializeV8Common(v8::Isolate* isolate)
289 { 289 {
290 isolate->AddGCPrologueCallback(V8GCController::gcPrologue); 290 isolate->AddGCPrologueCallback(V8GCController::gcPrologue);
291 isolate->AddGCEpilogueCallback(V8GCController::gcEpilogue); 291 isolate->AddGCEpilogueCallback(V8GCController::gcEpilogue);
292 if (RuntimeEnabledFeatures::traceWrappablesEnabled()) { 292 if (RuntimeEnabledFeatures::traceWrappablesEnabled()) {
293 ScriptWrappableVisitor* visitor = new ScriptWrappableVisitor(isolate); 293 std::unique_ptr<ScriptWrappableVisitor> visitor = std::unique_ptr<Script WrappableVisitor>(new ScriptWrappableVisitor(isolate));
haraken 2016/06/03 14:22:45 std::unique_ptr<> visitor(new ...);
294 isolate->SetEmbedderHeapTracer(visitor); 294 isolate->SetEmbedderHeapTracer(visitor.get());
295 V8PerIsolateData::from(isolate)->setScriptWrappableVisitor(std::move(vis itor));
295 } 296 }
296 297
297 v8::Debug::SetLiveEditEnabled(isolate, false); 298 v8::Debug::SetLiveEditEnabled(isolate, false);
298 299
299 isolate->SetMicrotasksPolicy(v8::MicrotasksPolicy::kScoped); 300 isolate->SetMicrotasksPolicy(v8::MicrotasksPolicy::kScoped);
300 } 301 }
301 302
302 namespace { 303 namespace {
303 304
304 class ArrayBufferAllocator : public v8::ArrayBuffer::Allocator { 305 class ArrayBufferAllocator : public v8::ArrayBuffer::Allocator {
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
364 ThreadState::mainThreadState()->addInterruptor(adoptPtr(new V8IsolateInterru ptor(isolate))); 365 ThreadState::mainThreadState()->addInterruptor(adoptPtr(new V8IsolateInterru ptor(isolate)));
365 ThreadState::mainThreadState()->registerTraceDOMWrappers(isolate, V8GCContro ller::traceDOMWrappers); 366 ThreadState::mainThreadState()->registerTraceDOMWrappers(isolate, V8GCContro ller::traceDOMWrappers);
366 367
367 V8PerIsolateData::from(isolate)->setThreadDebugger(adoptPtr(new MainThreadDe bugger(isolate))); 368 V8PerIsolateData::from(isolate)->setThreadDebugger(adoptPtr(new MainThreadDe bugger(isolate)));
368 } 369 }
369 370
370 void V8Initializer::shutdownMainThread() 371 void V8Initializer::shutdownMainThread()
371 { 372 {
372 ASSERT(isMainThread()); 373 ASSERT(isMainThread());
373 v8::Isolate* isolate = V8PerIsolateData::mainThreadIsolate(); 374 v8::Isolate* isolate = V8PerIsolateData::mainThreadIsolate();
375 isolate->SetEmbedderHeapTracer(nullptr);
374 V8PerIsolateData::willBeDestroyed(isolate); 376 V8PerIsolateData::willBeDestroyed(isolate);
375 V8PerIsolateData::destroy(isolate); 377 V8PerIsolateData::destroy(isolate);
376 } 378 }
377 379
378 static void reportFatalErrorInWorker(const char* location, const char* message) 380 static void reportFatalErrorInWorker(const char* location, const char* message)
379 { 381 {
380 // FIXME: We temporarily deal with V8 internal error situations such as out- of-memory by crashing the worker. 382 // FIXME: We temporarily deal with V8 internal error situations such as out- of-memory by crashing the worker.
381 CRASH(); 383 CRASH();
382 } 384 }
383 385
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
426 428
427 isolate->AddMessageListener(messageHandlerInWorker); 429 isolate->AddMessageListener(messageHandlerInWorker);
428 isolate->SetFatalErrorHandler(reportFatalErrorInWorker); 430 isolate->SetFatalErrorHandler(reportFatalErrorInWorker);
429 431
430 uint32_t here; 432 uint32_t here;
431 isolate->SetStackLimit(reinterpret_cast<uintptr_t>(&here - kWorkerMaxStackSi ze / sizeof(uint32_t*))); 433 isolate->SetStackLimit(reinterpret_cast<uintptr_t>(&here - kWorkerMaxStackSi ze / sizeof(uint32_t*)));
432 isolate->SetPromiseRejectCallback(promiseRejectHandlerInWorker); 434 isolate->SetPromiseRejectCallback(promiseRejectHandlerInWorker);
433 } 435 }
434 436
435 } // namespace blink 437 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698