third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp - Issue 2033583007: Store ScriptWrappableVisitor in V8PerIsolateData

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp

Issue 2033583007: Store ScriptWrappableVisitor in V8PerIsolateData (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: No need to deinitialize Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp b/third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp

index f2c049db85f3b606f91f425b876d1cb1ad19f2a5..e497d249a45da84872f7d5c354dd45e24a10c595 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp

@@ -290,8 +290,9 @@ static void initializeV8Common(v8::Isolate* isolate)

isolate->AddGCPrologueCallback(V8GCController::gcPrologue);

isolate->AddGCEpilogueCallback(V8GCController::gcEpilogue);

if (RuntimeEnabledFeatures::traceWrappablesEnabled()) {

- ScriptWrappableVisitor* visitor = new ScriptWrappableVisitor(isolate);

- isolate->SetEmbedderHeapTracer(visitor);

+ std::unique_ptr<ScriptWrappableVisitor> visitor(new ScriptWrappableVisitor(isolate));

+ isolate->SetEmbedderHeapTracer(visitor.get());

+ V8PerIsolateData::from(isolate)->setScriptWrappableVisitor(std::move(visitor));

}

v8::Debug::SetLiveEditEnabled(isolate, false);

« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.h » ('j') | no next file with comments »