third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp - Issue 2033583006: Change CSSValueList::removeAll and hasValue to take const CSSValue&

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp

Issue 2033583006: Change CSSValueList::removeAll and hasValue to take const CSSValue& (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp b/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp

index 5120de6608779c33db6dfcf51df7f0eaddbc1ace..61fa07b30e519f3763733f608651931d7ad54c89 100644

--- a/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp

@@ -222,7 +222,7 @@ static bool executeToggleStyleInList(LocalFrame& frame, EditorCommandSource sour

String newStyle("none");

if (selectedCSSValue->isValueList()) {

CSSValueList* selectedCSSValueList = toCSSValueList(selectedCSSValue);

- if (!selectedCSSValueList->removeAll(value))

+ if (!selectedCSSValueList->removeAll(*value))

selectedCSSValueList->append(value);

if (selectedCSSValueList->length())

newStyle = selectedCSSValueList->cssText();

« no previous file with comments | « third_party/WebKit/Source/core/editing/EditingStyle.cpp ('k') | no next file » | no next file with comments »