Compute ConstructorElement.returnType/type dynamically.

Compute ConstructorElement.returnType/type dynamically.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/17adc3ccd1ae19ee1f4bf7649cc6a9b517b9dbf1

[scheglov, 2016-06-03 16:08:12]

https://codereview.chromium.org/2033293003/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/resolver.dart (right):

https://codereview.chromium.org/2033293003/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/resolver.dart:9984: if (element == null) {
Do we still need this code?
We're not going to use "element" _here_ anymore.

[Paul Berry, 2016-06-03 16:10:17]

lgtm, assuming changes to resynthesize_test.dart are reverted.

https://codereview.chromium.org/2033293003/diff/1/pkg/analyzer/test/src/summa...
File pkg/analyzer/test/src/summary/resynthesize_test.dart (right):

https://codereview.chromium.org/2033293003/diff/1/pkg/analyzer/test/src/summa...
pkg/analyzer/test/src/summary/resynthesize_test.dart:3658: aaa: print(0);
I'd really prefer not to mix in a totally unrelated change into this CL.

I have a CL that fixes this test regression here:
https://codereview.chromium.org/2037973003/

[scheglov, 2016-06-03 16:11:57]

https://codereview.chromium.org/2033293003/diff/1/pkg/analyzer/test/src/summa...
File pkg/analyzer/test/src/summary/resynthesize_test.dart (right):

https://codereview.chromium.org/2033293003/diff/1/pkg/analyzer/test/src/summa...
pkg/analyzer/test/src/summary/resynthesize_test.dart:3658: aaa: print(0);
On 2016/06/03 16:10:17, Paul Berry wrote:
> I'd really prefer not to mix in a totally unrelated change into this CL.
> 
> I have a CL that fixes this test regression here:
> https://codereview.chromium.org/2037973003/

OK, reverted.

[Brian Wilkerson, 2016-06-03 16:15:24]

lgtm

https://codereview.chromium.org/2033293003/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/resolver.dart (right):

https://codereview.chromium.org/2033293003/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/resolver.dart:9984: if (element == null) {
It used to be the case that the element should never be null when we got to this
point in the analysis, but we found that it sometimes was. This code was added
to attempt to help us figure out why this was happening. If it's now valid for
the element to be null, then we don't need the check.

[scheglov, 2016-06-03 16:24:25]

Description was changed from

==========
Compute ConstructorElement.returnType/type dynamically.

R=brianwilkerson@google.com, paulberry@google.com
BUG=
==========

to

==========
Compute ConstructorElement.returnType/type dynamically.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/17adc3ccd1ae19ee1f4bf7649cc6a9b517b9dbf1
==========

[scheglov, 2016-06-03 16:24:26]

Committed patchset #1 (id:1) manually as
17adc3ccd1ae19ee1f4bf7649cc6a9b517b9dbf1 (presubmit successful).