Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: pkg/analyzer/lib/src/generated/testing/test_type_provider.dart

Issue 2033293003: Compute ConstructorElement.returnType/type dynamically. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« pkg/analyzer/lib/src/generated/resolver.dart ('K') | « pkg/analyzer/lib/src/generated/testing/element_factory.dart ('k') | pkg/analyzer/lib/src/summary/resynthesize.dart » ('j') | pkg/analyzer/test/src/summary/resynthesize_test.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/generated/testing/test_type_provider.dart
diff --git a/pkg/analyzer/lib/src/generated/testing/test_type_provider.dart b/pkg/analyzer/lib/src/generated/testing/test_type_provider.dart
index 64dadf252af1569a6713c41c80a37f7377d2e4d9..0a524fac9ec53f48d0bbc192a3589a7408bc3b96 100644
--- a/pkg/analyzer/lib/src/generated/testing/test_type_provider.dart
+++ b/pkg/analyzer/lib/src/generated/testing/test_type_provider.dart
@@ -149,7 +149,7 @@ class TestTypeProvider implements TypeProvider {
InterfaceType _typeType;
/**
- * The type representing typenames that can't be resolved.
+ * The type representing type names that can't be resolved.
*/
DartType _undefinedType;
@@ -684,10 +684,6 @@ class TestTypeProvider implements TypeProvider {
for (MethodElement method in classElement.methods) {
(method as ExecutableElementImpl).type = new FunctionTypeImpl(method);
}
- for (ConstructorElement constructor in classElement.constructors) {
- (constructor as ExecutableElementImpl).type =
- new FunctionTypeImpl(constructor);
- }
}
/**
« pkg/analyzer/lib/src/generated/resolver.dart ('K') | « pkg/analyzer/lib/src/generated/testing/element_factory.dart ('k') | pkg/analyzer/lib/src/summary/resynthesize.dart » ('j') | pkg/analyzer/test/src/summary/resynthesize_test.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698