Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1376)

Unified Diff: pkg/analyzer/lib/src/generated/testing/element_factory.dart

Issue 2033293003: Compute ConstructorElement.returnType/type dynamically. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer/lib/src/generated/testing/element_factory.dart
diff --git a/pkg/analyzer/lib/src/generated/testing/element_factory.dart b/pkg/analyzer/lib/src/generated/testing/element_factory.dart
index 2ffd0f9565afd5e29b6f5b647598b5a942bddc3e..ac293e74260cf4b8b77d4117f135a950a7c6dec5 100644
--- a/pkg/analyzer/lib/src/generated/testing/element_factory.dart
+++ b/pkg/analyzer/lib/src/generated/testing/element_factory.dart
@@ -96,7 +96,6 @@ class ElementFactory {
static ConstructorElementImpl constructorElement(
ClassElement definingClass, String name, bool isConst,
[List<DartType> argumentTypes]) {
- DartType type = definingClass.type;
ConstructorElementImpl constructor = name == null
? new ConstructorElementImpl("", -1)
: new ConstructorElementImpl(name, 0);
@@ -123,9 +122,7 @@ class ElementFactory {
} else {
constructor.parameters = <ParameterElement>[];
}
- constructor.returnType = type;
constructor.enclosingElement = definingClass;
- constructor.type = new FunctionTypeImpl(constructor);
if (!constructor.isSynthetic) {
constructor.constantInitializers = <ConstructorInitializer>[];
}
@@ -137,8 +134,7 @@ class ElementFactory {
[List<DartType> argumentTypes]) =>
constructorElement(definingClass, name, false, argumentTypes);
- static EnumElementImpl enumElement(
- TypeProvider typeProvider, String enumName,
+ static EnumElementImpl enumElement(TypeProvider typeProvider, String enumName,
[List<String> constantNames]) {
//
// Build the enum.

Powered by Google App Engine
This is Rietveld 408576698