Source/core/rendering/InlineFlowBox.h - Issue 203273003: Underline Thickness is not uniform

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/InlineFlowBox.h

Issue 203273003: Underline Thickness is not uniform (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fixing comments and adding new test case Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/rendering/InlineFlowBox.h

diff --git a/Source/core/rendering/InlineFlowBox.h b/Source/core/rendering/InlineFlowBox.h

index 7e683841ad009af66e648380556fec2feeda6cc7..ceedfc775e2aa137baf98dda7556e43b37e56469 100644

--- a/Source/core/rendering/InlineFlowBox.h

+++ b/Source/core/rendering/InlineFlowBox.h

@@ -115,6 +115,8 @@ public:

void paintFillLayer(const PaintInfo&, const Color&, const FillLayer*, const LayoutRect&, CompositeOperator = CompositeSourceOver);

void paintBoxShadow(const PaintInfo&, RenderStyle*, ShadowStyle, const LayoutRect&);

virtual void paint(PaintInfo&, const LayoutPoint&, LayoutUnit lineTop, LayoutUnit lineBottom) OVERRIDE;

+ virtual void paintDecorationStyle(PaintInfo&, const LayoutPoint&, LayoutUnit lineTop, LayoutUnit lineBottom, float decorationThickness) { };

+ virtual void getPaintDecorationSyle(PaintInfo&, const LayoutPoint&, float *) { };

leviw_travelin_and_unemployed 2014/03/21 20:43:08 Why are you overriding an empty method with more e

virtual bool nodeAtPoint(const HitTestRequest&, HitTestResult&, const HitTestLocation& locationInContainer, const LayoutPoint& accumulatedOffset, LayoutUnit lineTop, LayoutUnit lineBottom) OVERRIDE;

bool boxShadowCanBeAppliedToBackground(const FillLayer&) const;

« Source/core/rendering/InlineBox.h ('K') | « Source/core/rendering/InlineBox.h ('k') | Source/core/rendering/InlineFlowBox.cpp » ('j') | Source/core/rendering/InlineFlowBox.cpp » ('J')