Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Side by Side Diff: Source/core/rendering/InlineFlowBox.h

Issue 203273003: Underline Thickness is not uniform (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fixing comments and adding new test case Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2003, 2004, 2005, 2006, 2007 Apple Inc. All rights reserved. 2 * Copyright (C) 2003, 2004, 2005, 2006, 2007 Apple Inc. All rights reserved.
3 * 3 *
4 * This library is free software; you can redistribute it and/or 4 * This library is free software; you can redistribute it and/or
5 * modify it under the terms of the GNU Library General Public 5 * modify it under the terms of the GNU Library General Public
6 * License as published by the Free Software Foundation; either 6 * License as published by the Free Software Foundation; either
7 * version 2 of the License, or (at your option) any later version. 7 * version 2 of the License, or (at your option) any later version.
8 * 8 *
9 * This library is distributed in the hope that it will be useful, 9 * This library is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 97 matching lines...) Expand 10 before | Expand all | Expand 10 after
108 virtual void clearTruncation() OVERRIDE; 108 virtual void clearTruncation() OVERRIDE;
109 109
110 IntRect roundedFrameRect() const; 110 IntRect roundedFrameRect() const;
111 111
112 void paintBoxDecorations(PaintInfo&, const LayoutPoint&); 112 void paintBoxDecorations(PaintInfo&, const LayoutPoint&);
113 void paintMask(PaintInfo&, const LayoutPoint&); 113 void paintMask(PaintInfo&, const LayoutPoint&);
114 void paintFillLayers(const PaintInfo&, const Color&, const FillLayer*, const LayoutRect&, CompositeOperator = CompositeSourceOver); 114 void paintFillLayers(const PaintInfo&, const Color&, const FillLayer*, const LayoutRect&, CompositeOperator = CompositeSourceOver);
115 void paintFillLayer(const PaintInfo&, const Color&, const FillLayer*, const LayoutRect&, CompositeOperator = CompositeSourceOver); 115 void paintFillLayer(const PaintInfo&, const Color&, const FillLayer*, const LayoutRect&, CompositeOperator = CompositeSourceOver);
116 void paintBoxShadow(const PaintInfo&, RenderStyle*, ShadowStyle, const Layou tRect&); 116 void paintBoxShadow(const PaintInfo&, RenderStyle*, ShadowStyle, const Layou tRect&);
117 virtual void paint(PaintInfo&, const LayoutPoint&, LayoutUnit lineTop, Layou tUnit lineBottom) OVERRIDE; 117 virtual void paint(PaintInfo&, const LayoutPoint&, LayoutUnit lineTop, Layou tUnit lineBottom) OVERRIDE;
118 virtual void paintDecorationStyle(PaintInfo&, const LayoutPoint&, LayoutUnit lineTop, LayoutUnit lineBottom, float decorationThickness) { };
119 virtual void getPaintDecorationSyle(PaintInfo&, const LayoutPoint&, float *) { };
leviw_travelin_and_unemployed 2014/03/21 20:43:08 Why are you overriding an empty method with more e
118 virtual bool nodeAtPoint(const HitTestRequest&, HitTestResult&, const HitTes tLocation& locationInContainer, const LayoutPoint& accumulatedOffset, LayoutUnit lineTop, LayoutUnit lineBottom) OVERRIDE; 120 virtual bool nodeAtPoint(const HitTestRequest&, HitTestResult&, const HitTes tLocation& locationInContainer, const LayoutPoint& accumulatedOffset, LayoutUnit lineTop, LayoutUnit lineBottom) OVERRIDE;
119 121
120 bool boxShadowCanBeAppliedToBackground(const FillLayer&) const; 122 bool boxShadowCanBeAppliedToBackground(const FillLayer&) const;
121 123
122 virtual RenderLineBoxList* rendererLineBoxes() const; 124 virtual RenderLineBoxList* rendererLineBoxes() const;
123 125
124 // logicalLeft = left in a horizontal line and top in a vertical line. 126 // logicalLeft = left in a horizontal line and top in a vertical line.
125 LayoutUnit marginBorderPaddingLogicalLeft() const { return marginLogicalLeft () + borderLogicalLeft() + paddingLogicalLeft(); } 127 LayoutUnit marginBorderPaddingLogicalLeft() const { return marginLogicalLeft () + borderLogicalLeft() + paddingLogicalLeft(); }
126 LayoutUnit marginBorderPaddingLogicalRight() const { return marginLogicalRig ht() + borderLogicalRight() + paddingLogicalRight(); } 128 LayoutUnit marginBorderPaddingLogicalRight() const { return marginLogicalRig ht() + borderLogicalRight() + paddingLogicalRight(); }
127 LayoutUnit marginLogicalLeft() const 129 LayoutUnit marginLogicalLeft() const
(...skipping 239 matching lines...) Expand 10 before | Expand all | Expand 10 after
367 } 369 }
368 370
369 } // namespace WebCore 371 } // namespace WebCore
370 372
371 #ifndef NDEBUG 373 #ifndef NDEBUG
372 // Outside the WebCore namespace for ease of invocation from gdb. 374 // Outside the WebCore namespace for ease of invocation from gdb.
373 void showTree(const WebCore::InlineFlowBox*); 375 void showTree(const WebCore::InlineFlowBox*);
374 #endif 376 #endif
375 377
376 #endif // InlineFlowBox_h 378 #endif // InlineFlowBox_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698