Source/core/rendering/InlineBox.h - Issue 203273003: Underline Thickness is not uniform

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/InlineBox.h

Issue 203273003: Underline Thickness is not uniform (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fixing comments and adding new test case Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/platform/linux/fast/text/decoration-uniform-thickness-expected.txt ('k') | Source/core/rendering/InlineFlowBox.h » ('j') | Source/core/rendering/InlineFlowBox.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/InlineBox.h

diff --git a/Source/core/rendering/InlineBox.h b/Source/core/rendering/InlineBox.h

index 8f2a4ff153eaafcd7bf529e83a3c308729b8015f..bed7594473879c4c64a8cae47158ea0277abbfd3 100644

--- a/Source/core/rendering/InlineBox.h

+++ b/Source/core/rendering/InlineBox.h

@@ -96,6 +96,8 @@ public:

}

virtual void paint(PaintInfo&, const LayoutPoint&, LayoutUnit lineTop, LayoutUnit lineBottom);

+ virtual void paintDecorationStyle(PaintInfo&, const LayoutPoint&, LayoutUnit lineTop, LayoutUnit lineBottom, float decorationThickness) { };

+ virtual void getPaintDecorationSyle(PaintInfo&, const LayoutPoint&, float *) { };

leviw_travelin_and_unemployed 2014/03/21 20:43:08 This function name isn't very informative to me.

virtual bool nodeAtPoint(const HitTestRequest&, HitTestResult&, const HitTestLocation& locationInContainer, const LayoutPoint& accumulatedOffset, LayoutUnit lineTop, LayoutUnit lineBottom);

// InlineBoxes are allocated out of the rendering partition.