Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 203263004: Remove didChangeValueInTextField(HTMLInputElement&) and textFieldDidChange(const WebInputElement&) (Closed)

Created:
6 years, 9 months ago by ziran.sun
Modified:
6 years, 9 months ago
Reviewers:
tkent
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove didChangeValueInTextField(HTMLInputElement&) and textFieldDidChange(const WebInputElement&) The argument for these functions have been replaced by HTMLFormControlElement. Since changes at both chromium and blink sides are landed, it's safe to remove these functions. R=isherman@chromium.org, tkent@chromium.org BUG=332557 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169983

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -27 lines) Patch
M Source/core/page/ChromeClient.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/web/ChromeClientImpl.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/web/ChromeClientImpl.cpp View 1 chunk +0 lines, -9 lines 0 comments Download
M Source/web/tests/WebViewTest.cpp View 1 chunk +0 lines, -9 lines 0 comments Download
M public/web/WebAutofillClient.h View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
ziran.sun
Please review. Thanks!
6 years, 9 months ago (2014-03-18 13:25:01 UTC) #1
Ilya Sherman
Please note that the Chromium CL got reverted, so you'll need to wait for it ...
6 years, 9 months ago (2014-03-18 19:44:59 UTC) #2
ziran.sun
Hi tkent, the Chromium CL has landed. Is it okay to review and maybe land ...
6 years, 9 months ago (2014-03-25 19:55:06 UTC) #3
tkent
lgtm
6 years, 9 months ago (2014-03-25 21:45:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ziran.sun@samsung.com/203263004/1
6 years, 9 months ago (2014-03-25 21:46:04 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-25 22:50:09 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-25 22:50:09 UTC) #7
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 9 months ago (2014-03-25 22:54:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ziran.sun@samsung.com/203263004/1
6 years, 9 months ago (2014-03-25 22:55:00 UTC) #9
commit-bot: I haz the power
6 years, 9 months ago (2014-03-26 00:03:56 UTC) #10
Message was sent while issue was closed.
Change committed as 169983

Powered by Google App Engine
This is Rietveld 408576698