Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Side by Side Diff: Source/web/tests/WebViewTest.cpp

Issue 203263004: Remove didChangeValueInTextField(HTMLInputElement&) and textFieldDidChange(const WebInputElement&) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/web/ChromeClientImpl.cpp ('k') | public/web/WebAutofillClient.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011, 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2011, 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 1117 matching lines...) Expand 10 before | Expand all | Expand 10 after
1128 class MockAutofillClient : public WebAutofillClient { 1128 class MockAutofillClient : public WebAutofillClient {
1129 public: 1129 public:
1130 MockAutofillClient() 1130 MockAutofillClient()
1131 : m_ignoreTextChanges(false) 1131 : m_ignoreTextChanges(false)
1132 , m_textChangesWhileIgnored(0) 1132 , m_textChangesWhileIgnored(0)
1133 , m_textChangesWhileNotIgnored(0) { } 1133 , m_textChangesWhileNotIgnored(0) { }
1134 1134
1135 virtual ~MockAutofillClient() { } 1135 virtual ~MockAutofillClient() { }
1136 1136
1137 virtual void setIgnoreTextChanges(bool ignore) OVERRIDE { m_ignoreTextChange s = ignore; } 1137 virtual void setIgnoreTextChanges(bool ignore) OVERRIDE { m_ignoreTextChange s = ignore; }
1138 // FIXME: This function is to be removed once both chromium and blink change s
1139 // for BUG332557 are in.
1140 virtual void textFieldDidChange(const WebInputElement&) OVERRIDE
1141 {
1142 if (m_ignoreTextChanges)
1143 ++m_textChangesWhileIgnored;
1144 else
1145 ++m_textChangesWhileNotIgnored;
1146 }
1147 virtual void textFieldDidChange(const WebFormControlElement&) OVERRIDE 1138 virtual void textFieldDidChange(const WebFormControlElement&) OVERRIDE
1148 { 1139 {
1149 if (m_ignoreTextChanges) 1140 if (m_ignoreTextChanges)
1150 ++m_textChangesWhileIgnored; 1141 ++m_textChangesWhileIgnored;
1151 else 1142 else
1152 ++m_textChangesWhileNotIgnored; 1143 ++m_textChangesWhileNotIgnored;
1153 } 1144 }
1154 1145
1155 void clearChangeCounts() 1146 void clearChangeCounts()
1156 { 1147 {
(...skipping 584 matching lines...) Expand 10 before | Expand all | Expand 10 after
1741 testSelectionRootBounds("select_range_iframe_textarea_overflow.html", 1.0f); 1732 testSelectionRootBounds("select_range_iframe_textarea_overflow.html", 1.0f);
1742 1733
1743 // Basic page with scale factor. 1734 // Basic page with scale factor.
1744 testSelectionRootBounds("select_range_basic.html", 0.0f); 1735 testSelectionRootBounds("select_range_basic.html", 0.0f);
1745 testSelectionRootBounds("select_range_basic.html", 0.1f); 1736 testSelectionRootBounds("select_range_basic.html", 0.1f);
1746 testSelectionRootBounds("select_range_basic.html", 1.5f); 1737 testSelectionRootBounds("select_range_basic.html", 1.5f);
1747 testSelectionRootBounds("select_range_basic.html", 2.0f); 1738 testSelectionRootBounds("select_range_basic.html", 2.0f);
1748 } 1739 }
1749 1740
1750 } // namespace 1741 } // namespace
OLDNEW
« no previous file with comments | « Source/web/ChromeClientImpl.cpp ('k') | public/web/WebAutofillClient.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698