Source/web/tests/WebViewTest.cpp - Issue 203263004: Remove didChangeValueInTextField(HTMLInputElement&) and textFieldDidChange(const WebInputElement&)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/tests/WebViewTest.cpp

Issue 203263004: Remove didChangeValueInTextField(HTMLInputElement&) and textFieldDidChange(const WebInputElement&) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/tests/WebViewTest.cpp

diff --git a/Source/web/tests/WebViewTest.cpp b/Source/web/tests/WebViewTest.cpp

index 1789b3c0747325ebf0b8149a42de545b9bf6b938..0cdb33582b95feb4871fbdd5704a1b9cbd79290f 100644

--- a/Source/web/tests/WebViewTest.cpp

+++ b/Source/web/tests/WebViewTest.cpp

@@ -1135,15 +1135,6 @@ public:

virtual ~MockAutofillClient() { }

virtual void setIgnoreTextChanges(bool ignore) OVERRIDE { m_ignoreTextChanges = ignore; }

- // FIXME: This function is to be removed once both chromium and blink changes

- // for BUG332557 are in.

- virtual void textFieldDidChange(const WebInputElement&) OVERRIDE

- {

- if (m_ignoreTextChanges)

- ++m_textChangesWhileIgnored;

- else

- ++m_textChangesWhileNotIgnored;

- }

virtual void textFieldDidChange(const WebFormControlElement&) OVERRIDE

{

if (m_ignoreTextChanges)

« no previous file with comments | « Source/web/ChromeClientImpl.cpp ('k') | public/web/WebAutofillClient.h » ('j') | no next file with comments »