Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issue 2030813002: Correct typo in ui::TextEditCommandAuraLinux. (Closed)

Created:
4 years, 6 months ago by karandeepb
Modified:
4 years, 6 months ago
Reviewers:
tapted, sky, msw
CC:
chromium-reviews, yusukes+watch_chromium.org, tdresser+watch_chromium.org, tfarina, shuchen+watch_chromium.org, nona+watch_chromium.org, James Su, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@refactor6_remove_delete_command
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Correct typo in ui::TextEditCommandAuraLinux. This CL corrects the misspelt BEGINNING in ui::TextEditCommandAuraLinux. This is a follow-up to crrev.com/2031913002 and is fourth in series of CLs to replace resource ids with a ui::TextEditCommand enum for text editing commands in views::Textfield. Link to complete patch - http://crrev.com/2029733003 BUG=586985 Committed: https://crrev.com/2dea3aea30fd01f7a6050292d9a92ae26f457178 Cr-Commit-Position: refs/heads/master@{#400947}

Patch Set 1 : #

Patch Set 2 : Rebase #

Patch Set 3 : #

Patch Set 4 : Rebase. #

Patch Set 5 : Rebase. #

Patch Set 6 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -34 lines) Patch
M chrome/browser/ui/libgtk2ui/gtk2_key_bindings_handler.cc View 2 chunks +20 lines, -19 lines 0 comments Download
M ui/events/linux/text_edit_command_auralinux.h View 2 chunks +5 lines, -5 lines 0 comments Download
M ui/events/linux/text_edit_command_auralinux.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M ui/views/controls/textfield/textfield.cc View 1 2 3 4 5 2 chunks +5 lines, -5 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 31 (23 generated)
tapted
lgtm
4 years, 6 months ago (2016-06-06 07:48:51 UTC) #9
karandeepb
PTAL msw@ for ui/views/controls/ and chrome/browser/ review.
4 years, 6 months ago (2016-06-09 10:58:13 UTC) #18
msw
lgtm
4 years, 6 months ago (2016-06-10 00:55:28 UTC) #20
karandeepb
+sky for ui/events review.
4 years, 6 months ago (2016-06-16 00:02:09 UTC) #23
sky
LGTM
4 years, 6 months ago (2016-06-16 16:52:12 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2030813002/360001
4 years, 6 months ago (2016-06-21 10:06:24 UTC) #27
commit-bot: I haz the power
Committed patchset #6 (id:360001)
4 years, 6 months ago (2016-06-21 10:49:53 UTC) #29
commit-bot: I haz the power
4 years, 6 months ago (2016-06-21 10:54:07 UTC) #31
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/2dea3aea30fd01f7a6050292d9a92ae26f457178
Cr-Commit-Position: refs/heads/master@{#400947}

Powered by Google App Engine
This is Rietveld 408576698