Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 2031053004: Reduce LayoutSVGResource*Gradient building dependency on GradientData (Closed)

Created:
4 years, 6 months ago by fs
Modified:
4 years, 6 months ago
Reviewers:
f(malita)
CC:
fs, blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, krit, eae+blinkwatch, gyuyoung2, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reduce LayoutSVGResource*Gradient building dependency on GradientData The buildGradient() method can just create and return a Gradient instead of populating the GradientData struct it's being passed. Also make calculateGradientTransform() use the return value rather than an out variable, and make it const qualified. Make platformSpreadMethodFromSVGType static and use Traversal<> sugar in SVGGradientElement::buildStops. BUG=614368 Committed: https://crrev.com/aaa44070561b21e6ea2d9ae2acd2b0676c5b853e Cr-Commit-Position: refs/heads/master@{#397763}

Patch Set 1 #

Messages

Total messages: 10 (5 generated)
fs
Muscling in on your bug here a little bit - hopefully not taking things in ...
4 years, 6 months ago (2016-06-03 14:39:12 UTC) #4
f(malita)
Nice, LGTM!
4 years, 6 months ago (2016-06-03 15:23:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2031053004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2031053004/1
4 years, 6 months ago (2016-06-03 15:23:49 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-03 18:30:53 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 18:32:53 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/aaa44070561b21e6ea2d9ae2acd2b0676c5b853e
Cr-Commit-Position: refs/heads/master@{#397763}

Powered by Google App Engine
This is Rietveld 408576698