Reduce LayoutSVGResource*Gradient building dependency on GradientData

Reduce LayoutSVGResource*Gradient building dependency on GradientData

The buildGradient() method can just create and return a Gradient instead
of populating the GradientData struct it's being passed.
Also make calculateGradientTransform() use the return value rather than
an out variable, and make it const qualified. Make
platformSpreadMethodFromSVGType static and use Traversal<> sugar in
SVGGradientElement::buildStops.

BUG=614368
Committed: https://crrev.com/aaa44070561b21e6ea2d9ae2acd2b0676c5b853e
Cr-Commit-Position: refs/heads/master@{#397763}

[fs, 2016-06-03 13:53:40]

Description was changed from

==========
Make LayoutSVGResourceGradient not depend on GradientData

The buildGradient() method can just create and return a Gradient instead
of populating the GradientData struct it's being passed.
Also make calculateGradientTransform() use the return value rather than
an out variable, and make it const qualified. Make
platformSpreadMethodFromSVGType static and use Traversal<> sugar in
SVGGradientElement::buildStops.

BUG=614368
==========

to

==========
Reduce LayoutSVGResource*Gradient dependency on GradientData

The buildGradient() method can just create and return a Gradient instead
of populating the GradientData struct it's being passed.
Also make calculateGradientTransform() use the return value rather than
an out variable, and make it const qualified. Make
platformSpreadMethodFromSVGType static and use Traversal<> sugar in
SVGGradientElement::buildStops.

BUG=614368
==========

[fs, 2016-06-03 13:54:20]

Description was changed from

==========
Reduce LayoutSVGResource*Gradient dependency on GradientData

The buildGradient() method can just create and return a Gradient instead
of populating the GradientData struct it's being passed.
Also make calculateGradientTransform() use the return value rather than
an out variable, and make it const qualified. Make
platformSpreadMethodFromSVGType static and use Traversal<> sugar in
SVGGradientElement::buildStops.

BUG=614368
==========

to

==========
Reduce LayoutSVGResource*Gradient building dependency on GradientData

The buildGradient() method can just create and return a Gradient instead
of populating the GradientData struct it's being passed.
Also make calculateGradientTransform() use the return value rather than
an out variable, and make it const qualified. Make
platformSpreadMethodFromSVGType static and use Traversal<> sugar in
SVGGradientElement::buildStops.

BUG=614368
==========

[fs, 2016-06-03 14:39:11]

fs@opera.com changed reviewers:
+ fmalita@chromium.org

[fs, 2016-06-03 14:39:12]

Muscling in on your bug here a little bit - hopefully not taking things in any
direction perpendicular to what you're planning...

[f(malita), 2016-06-03 15:23:25]

Nice, LGTM!

[f(malita), 2016-06-03 15:23:29]

The CQ bit was checked by fmalita@chromium.org

[commit-bot: I haz the power, 2016-06-03 15:23:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2031053004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2031053004/1

[commit-bot: I haz the power, 2016-06-03 18:30:53]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-03 18:32:51]

Description was changed from

==========
Reduce LayoutSVGResource*Gradient building dependency on GradientData

The buildGradient() method can just create and return a Gradient instead
of populating the GradientData struct it's being passed.
Also make calculateGradientTransform() use the return value rather than
an out variable, and make it const qualified. Make
platformSpreadMethodFromSVGType static and use Traversal<> sugar in
SVGGradientElement::buildStops.

BUG=614368
==========

to

==========
Reduce LayoutSVGResource*Gradient building dependency on GradientData

The buildGradient() method can just create and return a Gradient instead
of populating the GradientData struct it's being passed.
Also make calculateGradientTransform() use the return value rather than
an out variable, and make it const qualified. Make
platformSpreadMethodFromSVGType static and use Traversal<> sugar in
SVGGradientElement::buildStops.

BUG=614368

Committed: https://crrev.com/aaa44070561b21e6ea2d9ae2acd2b0676c5b853e
Cr-Commit-Position: refs/heads/master@{#397763}
==========

[commit-bot: I haz the power, 2016-06-03 18:32:53]

Patchset 1 (id:??) landed as
https://crrev.com/aaa44070561b21e6ea2d9ae2acd2b0676c5b853e
Cr-Commit-Position: refs/heads/master@{#397763}