Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Unified Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceLinearGradient.cpp

Issue 2031053004: Reduce LayoutSVGResource*Gradient building dependency on GradientData (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceLinearGradient.cpp
diff --git a/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceLinearGradient.cpp b/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceLinearGradient.cpp
index 32c457d35fcb7d8b7606967353a43246f0b1a9c8..a64ca80e4ee3c4ed4693239d0a3568cc33bc0f41 100644
--- a/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceLinearGradient.cpp
+++ b/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceLinearGradient.cpp
@@ -50,12 +50,13 @@ FloatPoint LayoutSVGResourceLinearGradient::endPoint(const LinearGradientAttribu
return SVGLengthContext::resolvePoint(element(), attributes.gradientUnits(), *attributes.x2(), *attributes.y2());
}
-void LayoutSVGResourceLinearGradient::buildGradient(GradientData* gradientData) const
+PassRefPtr<Gradient> LayoutSVGResourceLinearGradient::buildGradient() const
{
const LinearGradientAttributes& attributes = this->attributes();
- gradientData->gradient = Gradient::create(startPoint(attributes), endPoint(attributes));
- gradientData->gradient->setSpreadMethod(platformSpreadMethodFromSVGType(attributes.spreadMethod()));
- addStops(gradientData, attributes.stops());
+ RefPtr<Gradient> gradient = Gradient::create(startPoint(attributes), endPoint(attributes));
+ gradient->setSpreadMethod(platformSpreadMethodFromSVGType(attributes.spreadMethod()));
+ addStops(*gradient, attributes.stops());
+ return gradient.release();
}
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698