third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceLinearGradient.h - Issue 2031053004: Reduce LayoutSVGResource*Gradient building dependency on GradientData

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceLinearGradient.h

Issue 2031053004: Reduce LayoutSVGResource*Gradient building dependency on GradientData (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceGradient.cpp ('k') | third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceLinearGradient.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceLinearGradient.h

diff --git a/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceLinearGradient.h b/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceLinearGradient.h

index 1a7a079acd4e25beb497dbaaae6c3223bde7e61f..c7f416fcb17dd022ee159dceee8072ad8ff7bd70 100644

--- a/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceLinearGradient.h

+++ b/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceLinearGradient.h

@@ -39,9 +39,9 @@ public:

LayoutSVGResourceType resourceType() const override { return s_resourceType; }

SVGUnitTypes::SVGUnitType gradientUnits() const override { return attributes().gradientUnits(); }

- void calculateGradientTransform(AffineTransform& transform) override { transform = attributes().gradientTransform(); }

+ AffineTransform calculateGradientTransform() const override { return attributes().gradientTransform(); }

bool collectGradientAttributes(SVGGradientElement*) override;

- void buildGradient(GradientData*) const override;

+ PassRefPtr<Gradient> buildGradient() const override;

FloatPoint startPoint(const LinearGradientAttributes&) const;

FloatPoint endPoint(const LinearGradientAttributes&) const;