Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 2064053002: Move ui/events/linux/* to ui/base/ime/linux/. (Closed)

Created:
4 years, 6 months ago by karandeepb
Modified:
4 years, 6 months ago
CC:
chrome-apps-syd-reviews_chromium.org, chromium-reviews, nona+watch_chromium.org, shuchen+watch_chromium.org, James Su, tdresser+watch_chromium.org, yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@refactor7_correct_text_edit_command_aura_typo
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move ui/events/linux/* to ui/base/ime/linux/. This CL moves the files: - text_edit_command_auralinux.h - text_edit_command_auralinux.cc - text_edit_key_bindings_delegate_auralinux.h - text_edit_key_bindings_delegate_auralinux.cc from ui/events/linux to ui/base/ime/linux. These files are not related to events and hence are better suited to be in ui/base/ime. Also, currently, ui/base/ime depends on ui/events. In a follow-up crrev.com/2034623002, the above files (in ui/events) need to depend on ui/base/ime/text_edit_commands.h (in ui/base/ime). This CL helps avoid the circular dependency my moving these files to ui/base/ime. This is a follow-up to crrev.com/2030813002 and is fifth in series of CLs to replace resource ids with a ui::TextEditCommand enum for text editing commands in views::Textfield. Link to complete patch - http://crrev.com/2029733003 BUG=586985 Committed: https://crrev.com/e6200335a950405203f5f078d744fc09d00a3861 Cr-Commit-Position: refs/heads/master@{#400963}

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : Rebase. #

Patch Set 4 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -320 lines) Patch
M chrome/browser/ui/browser_command_controller.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/libgtk2ui/gtk2_key_bindings_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/libgtk2ui/gtk2_ui.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/ime/BUILD.gn View 1 chunk +9 lines, -0 lines 0 comments Download
A + ui/base/ime/linux/text_edit_command_auralinux.h View 1 3 chunks +7 lines, -7 lines 0 comments Download
A + ui/base/ime/linux/text_edit_command_auralinux.cc View 1 chunk +1 line, -1 line 0 comments Download
A + ui/base/ime/linux/text_edit_key_bindings_delegate_auralinux.h View 1 3 chunks +8 lines, -8 lines 0 comments Download
A + ui/base/ime/linux/text_edit_key_bindings_delegate_auralinux.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/ime/ui_base_ime.gyp View 2 chunks +10 lines, -0 lines 0 comments Download
M ui/events/BUILD.gn View 1 2 1 chunk +0 lines, -9 lines 0 comments Download
M ui/events/events.gyp View 1 2 2 chunks +0 lines, -12 lines 0 comments Download
D ui/events/linux/text_edit_command_auralinux.h View 1 chunk +0 lines, -82 lines 0 comments Download
D ui/events/linux/text_edit_command_auralinux.cc View 1 chunk +0 lines, -124 lines 0 comments Download
D ui/events/linux/text_edit_key_bindings_delegate_auralinux.h View 1 chunk +0 lines, -43 lines 0 comments Download
D ui/events/linux/text_edit_key_bindings_delegate_auralinux.cc View 1 chunk +0 lines, -23 lines 0 comments Download
M ui/views/controls/textfield/textfield.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/controls/textfield/textfield_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/linux_ui/linux_ui.h View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 20 (11 generated)
karandeepb
PTAL msw@. Thanks.
4 years, 6 months ago (2016-06-15 06:26:48 UTC) #5
msw
lgtm
4 years, 6 months ago (2016-06-15 17:08:44 UTC) #8
karandeepb
+sky for ui/base, ui/events and ui/views/linux_ui/linux_ui.h review. +jochen for content/ review
4 years, 6 months ago (2016-06-16 00:09:22 UTC) #10
sky
LGTM
4 years, 6 months ago (2016-06-16 16:56:24 UTC) #11
karandeepb
ping jochen@ for content/ review.
4 years, 6 months ago (2016-06-20 00:07:09 UTC) #12
jochen (gone - plz use gerrit)
lgtm
4 years, 6 months ago (2016-06-20 11:34:27 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2064053002/100001
4 years, 6 months ago (2016-06-21 11:24:16 UTC) #16
commit-bot: I haz the power
Committed patchset #4 (id:100001)
4 years, 6 months ago (2016-06-21 12:26:30 UTC) #18
commit-bot: I haz the power
4 years, 6 months ago (2016-06-21 12:28:04 UTC) #20
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/e6200335a950405203f5f078d744fc09d00a3861
Cr-Commit-Position: refs/heads/master@{#400963}

Powered by Google App Engine
This is Rietveld 408576698