Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(67)

Issue 2030243004: Set Event.composed flag correctly for some of UA UIEvents (Closed)

Created:
3 years ago by hayato
Modified:
3 years ago
Reviewers:
tkent, kochi
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Set Event.composed flag correctly for some of UA UIEvents See https://github.com/w3c/webcomponents/issues/513 for the context. See also the previous CL: https://codereview.chromium.org/2012423004, where Event.composed was introduced. The change is visible only when Shadow DOM v1 is used. BUG=531990, 616654 Committed: https://crrev.com/557ec07b3ab3b1535e71f86310f38b3517acc980 Cr-Commit-Position: refs/heads/master@{#397681}

Patch Set 1 #

Patch Set 2 : rebased #

Total comments: 6

Patch Set 3 : addressed #

Messages

Total messages: 23 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2030243004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2030243004/1
3 years ago (2016-06-03 07:38:25 UTC) #2
hayato
rebased
3 years ago (2016-06-03 07:49:08 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2030243004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2030243004/20001
3 years ago (2016-06-03 07:49:15 UTC) #5
hayato
PTAL
3 years ago (2016-06-03 07:56:50 UTC) #9
kochi
https://codereview.chromium.org/2030243004/diff/20001/third_party/WebKit/LayoutTests/shadow-dom/event-composed.html File third_party/WebKit/LayoutTests/shadow-dom/event-composed.html (right): https://codereview.chromium.org/2030243004/diff/20001/third_party/WebKit/LayoutTests/shadow-dom/event-composed.html#newcode76 third_party/WebKit/LayoutTests/shadow-dom/event-composed.html:76: }, 'An UA click event should not be scoped'); ...
3 years ago (2016-06-03 08:45:57 UTC) #10
hayato
Thank you for the review. https://codereview.chromium.org/2030243004/diff/20001/third_party/WebKit/LayoutTests/shadow-dom/event-composed.html File third_party/WebKit/LayoutTests/shadow-dom/event-composed.html (right): https://codereview.chromium.org/2030243004/diff/20001/third_party/WebKit/LayoutTests/shadow-dom/event-composed.html#newcode76 third_party/WebKit/LayoutTests/shadow-dom/event-composed.html:76: }, 'An UA click ...
3 years ago (2016-06-03 09:03:05 UTC) #11
kochi
On 2016/06/03 09:03:05, hayato wrote: > Thank you for the review. > > https://codereview.chromium.org/2030243004/diff/20001/third_party/WebKit/LayoutTests/shadow-dom/event-composed.html > ...
3 years ago (2016-06-03 09:22:41 UTC) #12
hayato
addressed
3 years ago (2016-06-03 09:26:44 UTC) #14
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2030243004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2030243004/40001
3 years ago (2016-06-03 09:26:51 UTC) #15
hayato
Ops. Done. :)
3 years ago (2016-06-03 09:27:15 UTC) #16
kochi
lgtm
3 years ago (2016-06-03 09:28:04 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2030243004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2030243004/40001
3 years ago (2016-06-03 09:28:38 UTC) #20
commit-bot: I haz the power
Committed patchset #3 (id:40001)
3 years ago (2016-06-03 11:19:30 UTC) #21
commit-bot: I haz the power
3 years ago (2016-06-03 11:20:40 UTC) #23
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/557ec07b3ab3b1535e71f86310f38b3517acc980
Cr-Commit-Position: refs/heads/master@{#397681}

Powered by Google App Engine
This is Rietveld 408576698