Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2030243004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2030243004/1
4 years, 6 months ago
(2016-06-03 07:38:25 UTC)
#2
4 years, 6 months ago
(2016-06-03 07:49:08 UTC)
#4
rebased
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2030243004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2030243004/20001
4 years, 6 months ago
(2016-06-03 07:49:15 UTC)
#5
Description was changed from ========== Fix Event.composed BUG= ========== to ========== Set Event.composed flag correctly ...
4 years, 6 months ago
(2016-06-03 07:53:27 UTC)
#6
Description was changed from
==========
Fix Event.composed
BUG=
==========
to
==========
Set Event.composed flag correctly for some of UA UIEvents
See https://github.com/w3c/webcomponents/issues/513 for the context.
The change is visible only when Shadow DOM v1 is used.
BUG=531990,616654
==========
hayato
Description was changed from ========== Set Event.composed flag correctly for some of UA UIEvents See ...
4 years, 6 months ago
(2016-06-03 07:56:16 UTC)
#7
Description was changed from
==========
Set Event.composed flag correctly for some of UA UIEvents
See https://github.com/w3c/webcomponents/issues/513 for the context.
The change is visible only when Shadow DOM v1 is used.
BUG=531990,616654
==========
to
==========
Set Event.composed flag correctly for some of UA UIEvents
See https://github.com/w3c/webcomponents/issues/513 for the context.
See also the previous CL: https://codereview.chromium.org/2012423004, where
Event.composed was introduced.
The change is visible only when Shadow DOM v1 is used.
BUG=531990,616654
==========
4 years, 6 months ago
(2016-06-03 07:56:50 UTC)
#9
PTAL
kochi
https://codereview.chromium.org/2030243004/diff/20001/third_party/WebKit/LayoutTests/shadow-dom/event-composed.html File third_party/WebKit/LayoutTests/shadow-dom/event-composed.html (right): https://codereview.chromium.org/2030243004/diff/20001/third_party/WebKit/LayoutTests/shadow-dom/event-composed.html#newcode76 third_party/WebKit/LayoutTests/shadow-dom/event-composed.html:76: }, 'An UA click event should not be scoped'); ...
4 years, 6 months ago
(2016-06-03 08:45:57 UTC)
#10
Thank you for the review. https://codereview.chromium.org/2030243004/diff/20001/third_party/WebKit/LayoutTests/shadow-dom/event-composed.html File third_party/WebKit/LayoutTests/shadow-dom/event-composed.html (right): https://codereview.chromium.org/2030243004/diff/20001/third_party/WebKit/LayoutTests/shadow-dom/event-composed.html#newcode76 third_party/WebKit/LayoutTests/shadow-dom/event-composed.html:76: }, 'An UA click ...
4 years, 6 months ago
(2016-06-03 09:03:05 UTC)
#11
On 2016/06/03 09:03:05, hayato wrote: > Thank you for the review. > > https://codereview.chromium.org/2030243004/diff/20001/third_party/WebKit/LayoutTests/shadow-dom/event-composed.html > ...
4 years, 6 months ago
(2016-06-03 09:22:41 UTC)
#12
4 years, 6 months ago
(2016-06-03 09:26:44 UTC)
#14
addressed
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2030243004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2030243004/40001
4 years, 6 months ago
(2016-06-03 09:26:51 UTC)
#15
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2030243004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2030243004/40001
4 years, 6 months ago
(2016-06-03 09:28:38 UTC)
#20
Issue 2030243004: Set Event.composed flag correctly for some of UA UIEvents
(Closed)
Created 4 years, 6 months ago by hayato
Modified 4 years, 6 months ago
Reviewers: kochi, tkent
Base URL: https://chromium.googlesource.com/chromium/src.git@master
Comments: 6