third_party/WebKit/Source/core/events/CompositionEvent.cpp - Issue 2030243004: Set Event.composed flag correctly for some of UA UIEvents

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/events/CompositionEvent.cpp

Issue 2030243004: Set Event.composed flag correctly for some of UA UIEvents (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/shadow-dom/resources/shadow-dom.js ('k') | third_party/WebKit/Source/core/events/Event.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/events/CompositionEvent.cpp

diff --git a/third_party/WebKit/Source/core/events/CompositionEvent.cpp b/third_party/WebKit/Source/core/events/CompositionEvent.cpp

index d5ca38bc945e7d1768c7d06bbf74fbbde0958ad2..f81a716804218efe5ff4f5a6c079eeafbd39235a 100644

--- a/third_party/WebKit/Source/core/events/CompositionEvent.cpp

+++ b/third_party/WebKit/Source/core/events/CompositionEvent.cpp

@@ -33,7 +33,7 @@ CompositionEvent::CompositionEvent()

}

CompositionEvent::CompositionEvent(const AtomicString& type, AbstractView* view, const String& data)

- : UIEvent(type, true, true, view, 0, InputDeviceCapabilities::doesntFireTouchEventsSourceCapabilities())

+ : UIEvent(type, true, true, ComposedMode::Composed, view, 0, InputDeviceCapabilities::doesntFireTouchEventsSourceCapabilities())

, m_data(data)

{

}

« no previous file with comments | « third_party/WebKit/LayoutTests/shadow-dom/resources/shadow-dom.js ('k') | third_party/WebKit/Source/core/events/Event.h » ('j') | no next file with comments »