Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: third_party/WebKit/Source/core/events/UIEvent.cpp

Issue 2030243004: Set Event.composed flag correctly for some of UA UIEvents (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressed Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2001 Peter Kelly (pmk@post.com) 2 * Copyright (C) 2001 Peter Kelly (pmk@post.com)
3 * Copyright (C) 2001 Tobias Anton (anton@stud.fbi.fh-darmstadt.de) 3 * Copyright (C) 2001 Tobias Anton (anton@stud.fbi.fh-darmstadt.de)
4 * Copyright (C) 2006 Samuel Weinig (sam.weinig@gmail.com) 4 * Copyright (C) 2006 Samuel Weinig (sam.weinig@gmail.com)
5 * Copyright (C) 2003, 2005, 2006, 2008 Apple Inc. All rights reserved. 5 * Copyright (C) 2003, 2005, 2006, 2008 Apple Inc. All rights reserved.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 14 matching lines...) Expand all
25 25
26 namespace blink { 26 namespace blink {
27 27
28 UIEvent::UIEvent() 28 UIEvent::UIEvent()
29 : m_detail(0) 29 : m_detail(0)
30 , m_sourceCapabilities(nullptr) 30 , m_sourceCapabilities(nullptr)
31 { 31 {
32 } 32 }
33 33
34 // TODO(lanwei): Will add sourceCapabilities to all the subclass of UIEvent late r, see https://crbug.com/476530. 34 // TODO(lanwei): Will add sourceCapabilities to all the subclass of UIEvent late r, see https://crbug.com/476530.
35 UIEvent::UIEvent(const AtomicString& eventType, bool canBubbleArg, bool cancelab leArg, AbstractView* viewArg, int detailArg, InputDeviceCapabilities* sourceCapa bilitiesArg) 35 UIEvent::UIEvent(const AtomicString& eventType, bool canBubbleArg, bool cancelab leArg, ComposedMode composedMode, AbstractView* viewArg, int detailArg, InputDev iceCapabilities* sourceCapabilitiesArg)
36 : Event(eventType, canBubbleArg, cancelableArg) 36 : Event(eventType, canBubbleArg, cancelableArg, composedMode)
37 , m_view(viewArg) 37 , m_view(viewArg)
38 , m_detail(detailArg) 38 , m_detail(detailArg)
39 , m_sourceCapabilities(sourceCapabilitiesArg) 39 , m_sourceCapabilities(sourceCapabilitiesArg)
40 { 40 {
41 } 41 }
42 42
43 UIEvent::UIEvent(const AtomicString& eventType, bool canBubbleArg, bool cancelab leArg, double platformTimeStamp, AbstractView* viewArg, int detailArg, InputDevi ceCapabilities* sourceCapabilitiesArg) 43 UIEvent::UIEvent(const AtomicString& eventType, bool canBubbleArg, bool cancelab leArg, ComposedMode composedMode, double platformTimeStamp, AbstractView* viewAr g, int detailArg, InputDeviceCapabilities* sourceCapabilitiesArg)
44 : Event(eventType, canBubbleArg, cancelableArg, platformTimeStamp) 44 : Event(eventType, canBubbleArg, cancelableArg, composedMode, platformTimeSt amp)
45 , m_view(viewArg) 45 , m_view(viewArg)
46 , m_detail(detailArg) 46 , m_detail(detailArg)
47 , m_sourceCapabilities(sourceCapabilitiesArg) 47 , m_sourceCapabilities(sourceCapabilitiesArg)
48 { 48 {
49 } 49 }
50 50
51 UIEvent::UIEvent(const AtomicString& eventType, const UIEventInit& initializer) 51 UIEvent::UIEvent(const AtomicString& eventType, const UIEventInit& initializer)
52 : Event(eventType, initializer) 52 : Event(eventType, initializer)
53 , m_view(initializer.view()) 53 , m_view(initializer.view())
54 , m_detail(initializer.detail()) 54 , m_detail(initializer.detail())
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
93 } 93 }
94 94
95 DEFINE_TRACE(UIEvent) 95 DEFINE_TRACE(UIEvent)
96 { 96 {
97 visitor->trace(m_view); 97 visitor->trace(m_view);
98 visitor->trace(m_sourceCapabilities); 98 visitor->trace(m_sourceCapabilities);
99 Event::trace(visitor); 99 Event::trace(visitor);
100 } 100 }
101 101
102 } // namespace blink 102 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/events/UIEvent.h ('k') | third_party/WebKit/Source/core/events/UIEventWithKeyState.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698