cc::SharedQuadState: drop CopyFrom and add copy constructor

cc::SharedQuadState: drop CopyFrom and add copy constructor

In order to make cc::SharedQuadState mojo::Array / std::vector friendly
this CL gives it a copy constructor. This CL also drops CopyFrom because
it's redundant.

BUG=611802
TBR=tsepez@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/95998766b1ea36f05a974744e570850bf7b8432b
Cr-Commit-Position: refs/heads/master@{#397364}

[Fady Samuel, 2016-06-01 22:05:02]

Description was changed from

==========
cc::SharedQuadState: drop CopyFrom and add copy constructor

In order to make cc::SharedQuadState mojo::Array / std::vector friendly
this CL gives it a copy constructor. This CL also drops CopyFrom because
it's redundant.

BUG=611802
==========

to

==========
cc::SharedQuadState: drop CopyFrom and add copy constructor

In order to make cc::SharedQuadState mojo::Array / std::vector friendly
this CL gives it a copy constructor. This CL also drops CopyFrom because
it's redundant.

BUG=611802
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[Fady Samuel, 2016-06-01 22:05:42]

fsamuel@chromium.org changed reviewers:
+ danakj@chromium.org

[Fady Samuel, 2016-06-01 22:05:44]

PTAL Dana This is what we just talked about as a pre-requisite for serializing
cc::SharedQuadState over mojo.

[danakj, 2016-06-01 22:12:48]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-01 22:13:26]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2029813002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2029813002/20001

[danakj, 2016-06-01 22:37:46]

https://codereview.chromium.org/2029813002/diff/20001/cc/quads/shared_quad_st...
File cc/quads/shared_quad_state.cc (right):

https://codereview.chromium.org/2029813002/diff/20001/cc/quads/shared_quad_st...
cc/quads/shared_quad_state.cc:22: SharedQuadState::SharedQuadState(const
SharedQuadState& other)
use = default

[Fady Samuel, 2016-06-01 22:44:13]

PTAL

https://codereview.chromium.org/2029813002/diff/20001/cc/quads/shared_quad_st...
File cc/quads/shared_quad_state.cc (right):

https://codereview.chromium.org/2029813002/diff/20001/cc/quads/shared_quad_st...
cc/quads/shared_quad_state.cc:22: SharedQuadState::SharedQuadState(const
SharedQuadState& other)
On 2016/06/01 22:37:46, danakj wrote:
> use = default

Done.

[danakj, 2016-06-01 22:45:07]

LGTM

[Fady Samuel, 2016-06-01 22:46:06]

The CQ bit was checked by fsamuel@chromium.org

[Fady Samuel, 2016-06-01 22:46:10]

The CQ bit was unchecked by fsamuel@chromium.org

[Fady Samuel, 2016-06-01 22:47:09]

fsamuel@chromium.org changed reviewers:
+ tsepez@chromium.org

[Fady Samuel, 2016-06-01 22:47:10]

+tsepez@ for ipc (I'm TBRing since it's a trivial transformation of a test).

[Fady Samuel, 2016-06-01 22:47:23]

Description was changed from

==========
cc::SharedQuadState: drop CopyFrom and add copy constructor

In order to make cc::SharedQuadState mojo::Array / std::vector friendly
this CL gives it a copy constructor. This CL also drops CopyFrom because
it's redundant.

BUG=611802
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc::SharedQuadState: drop CopyFrom and add copy constructor

In order to make cc::SharedQuadState mojo::Array / std::vector friendly
this CL gives it a copy constructor. This CL also drops CopyFrom because
it's redundant.

BUG=611802
TBR=tsepez@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[Fady Samuel, 2016-06-01 22:47:28]

The CQ bit was checked by fsamuel@chromium.org

[commit-bot: I haz the power, 2016-06-01 22:48:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2029813002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2029813002/40001

[Tom Sepez, 2016-06-01 22:50:33]

lgtm

[commit-bot: I haz the power, 2016-06-02 00:38:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-02 00:38:10]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Fady Samuel, 2016-06-02 00:38:36]

The CQ bit was checked by fsamuel@chromium.org

[commit-bot: I haz the power, 2016-06-02 00:40:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2029813002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2029813002/40001

[commit-bot: I haz the power, 2016-06-02 02:32:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-02 02:32:56]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Fady Samuel, 2016-06-02 02:41:47]

The CQ bit was checked by fsamuel@chromium.org

[commit-bot: I haz the power, 2016-06-02 02:42:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2029813002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2029813002/40001

[commit-bot: I haz the power, 2016-06-02 03:27:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-02 03:27:11]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Fady Samuel, 2016-06-02 03:27:33]

The CQ bit was checked by fsamuel@chromium.org

[commit-bot: I haz the power, 2016-06-02 03:27:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2029813002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2029813002/40001

[commit-bot: I haz the power, 2016-06-02 04:16:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-02 04:16:36]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Fady Samuel, 2016-06-02 10:41:02]

The CQ bit was checked by fsamuel@chromium.org

[commit-bot: I haz the power, 2016-06-02 10:41:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2029813002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2029813002/40001

[commit-bot: I haz the power, 2016-06-02 11:22:34]

Description was changed from

==========
cc::SharedQuadState: drop CopyFrom and add copy constructor

In order to make cc::SharedQuadState mojo::Array / std::vector friendly
this CL gives it a copy constructor. This CL also drops CopyFrom because
it's redundant.

BUG=611802
TBR=tsepez@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc::SharedQuadState: drop CopyFrom and add copy constructor

In order to make cc::SharedQuadState mojo::Array / std::vector friendly
this CL gives it a copy constructor. This CL also drops CopyFrom because
it's redundant.

BUG=611802
TBR=tsepez@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[commit-bot: I haz the power, 2016-06-02 11:22:35]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-02 11:23:33]

Description was changed from

==========
cc::SharedQuadState: drop CopyFrom and add copy constructor

In order to make cc::SharedQuadState mojo::Array / std::vector friendly
this CL gives it a copy constructor. This CL also drops CopyFrom because
it's redundant.

BUG=611802
TBR=tsepez@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc::SharedQuadState: drop CopyFrom and add copy constructor

In order to make cc::SharedQuadState mojo::Array / std::vector friendly
this CL gives it a copy constructor. This CL also drops CopyFrom because
it's redundant.

BUG=611802
TBR=tsepez@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/95998766b1ea36f05a974744e570850bf7b8432b
Cr-Commit-Position: refs/heads/master@{#397364}
==========

[commit-bot: I haz the power, 2016-06-02 11:23:39]

Patchset 3 (id:??) landed as
https://crrev.com/95998766b1ea36f05a974744e570850bf7b8432b
Cr-Commit-Position: refs/heads/master@{#397364}